Remove calls to User::email() from chrome/browser/ui/webui/*

Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
Committed: https://crrev.com/e3ffc4d33b72e1fa0ae6271ece1279fb98d0c0ea
Cr-Commit-Position: refs/heads/master@{#429724}

[Alexander Alekseev, 2016-11-03 05:07:49]

alemate@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Alexander Alekseev, 2016-11-03 05:07:50]

Please review.

[Alexander Alekseev, 2016-11-03 05:07:57]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 05:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 06:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 06:17:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xiyuan, 2016-11-03 16:59:21]

lgtm

[Alexander Alekseev, 2016-11-03 21:24:31]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-11-03 21:26:36]

Description was changed from

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a tep to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
==========

to

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
==========

[commit-bot: I haz the power, 2016-11-03 21:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:37:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Alekseev, 2016-11-03 22:27:49]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Alexander Alekseev, 2016-11-03 22:27:49]

+ stevenjb@ for chrome/browser/ui/webui/options/

Please review.

[stevenjb, 2016-11-03 22:52:35]

lgtm with one question/caveat.

https://codereview.chromium.org/2471993002/diff/1/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui_handler.cc (right):

https://codereview.chromium.org/2471993002/diff/1/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui_handler.cc:294: void OnPolicyUpdated(const
std::string& user_id) override;
Is there an issue tracking migration of the policy code to use AccountId? It
seems like something that should be updated (and AccountId should be used here)
but if we replace all of these calls to GetAccountId().GetUserEmail() we might
miss it?

[Alexander Alekseev, 2016-11-03 22:55:23]

https://codereview.chromium.org/2471993002/diff/1/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui_handler.cc (right):

https://codereview.chromium.org/2471993002/diff/1/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui_handler.cc:294: void OnPolicyUpdated(const
std::string& user_id) override;
On 2016/11/03 22:52:35, stevenjb wrote:
> Is there an issue tracking migration of the policy code to use AccountId? It
> seems like something that should be updated (and AccountId should be used
here)
> but if we replace all of these calls to GetAccountId().GetUserEmail() we might
> miss it?

This is the same issue. I am going to implement it in (near) future.

[Alexander Alekseev, 2016-11-03 22:55:41]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:56:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:28:33]

Description was changed from

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
==========

to

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
==========

[commit-bot: I haz the power, 2016-11-03 23:28:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 23:30:03]

Description was changed from

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823
==========

to

==========
Remove calls to User::email() from chrome/browser/ui/webui/*

As a step to removing User::email(), this CL replaces calls to User::email()
with User::GetAccountId().GetUserEmail() in chrome/browser/ui/webui/*

BUG=462823

Committed: https://crrev.com/e3ffc4d33b72e1fa0ae6271ece1279fb98d0c0ea
Cr-Commit-Position: refs/heads/master@{#429724}
==========

[commit-bot: I haz the power, 2016-11-03 23:30:04]

Patchset 1 (id:??) landed as
https://crrev.com/e3ffc4d33b72e1fa0ae6271ece1279fb98d0c0ea
Cr-Commit-Position: refs/heads/master@{#429724}