Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html

Issue 2471933002: Reland of Improve how the column balancer handles top margins on floats. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ColumnBalancer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html
diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html
new file mode 100644
index 0000000000000000000000000000000000000000..e2a6bd98183ac72a0b221941e5d7ec4afc7a575a
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<p>There should be a cyan square in the bottom right corner of a blue rectangle.</p>
+<div id="multicol" style="position:relative; columns:3; line-height:20px; orphans:1; widows:1; background:blue;">
+ <br>
+ <br>
+ <br>
+ <br>
+ <div id="elm" style="float:right; margin-top:30px; width:40px; line-height:40px; background:cyan;">
+ <br>
+ </div>
+</div>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script>
+test(() => {
+ var multicol = document.getElementById("multicol");
+ var elm = document.getElementById("elm");
+ assert_equals(multicol.offsetHeight, 70);
+ assert_equals(elm.offsetTop, 30);
+}, "Float that should fit its top margin together with the border box.");
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ColumnBalancer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698