Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Compatibility problems have been seen with the 3.1 Core Profile
context.

Remove the earlier device ID-based workarounds, but leave in the code
for the create_default_gl_context workaround.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/79d13b8fa8301665906bfdd7de27643c8b411502
Cr-Commit-Position: refs/heads/master@{#430114}

[Ken Russell (switch to Gerrit), 2016-11-04 17:34:42]

Description was changed from

==========
Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Compatibility problems have been seen with the 3.1 Core Profile
context.

Remove the earlier device ID-based workarounds, but leave in the code
for the create_default_gl_context workaround.

BUG=659030
==========

to

==========
Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Compatibility problems have been seen with the 3.1 Core Profile
context.

Remove the earlier device ID-based workarounds, but leave in the code
for the create_default_gl_context workaround.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-04 17:36:49]

kbr@chromium.org changed reviewers:
+ cwallez@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-04 17:36:50]

Yang, Yunchao, Qiankun: could you please apply and build this patch locally and
see, on an affected Mesa version, whether it still solves the problem of Google
Maps' labels not rendering correctly?

zmo, cwallez: PTAL, but I would like to hold off CQ'ing this until it's known
that it actually works.

[Zhenyao Mo, 2016-11-04 17:48:25]

On 2016/11/04 17:36:50, Ken Russell wrote:
> Yang, Yunchao, Qiankun: could you please apply and build this patch locally
and
> see, on an affected Mesa version, whether it still solves the problem of
Google
> Maps' labels not rendering correctly?
> 
> zmo, cwallez: PTAL, but I would like to hold off CQ'ing this until it's known
> that it actually works.
lgtm

[Corentin Wallez, 2016-11-04 18:03:16]

On 2016/11/04 at 17:48:25, zmo wrote:
> On 2016/11/04 17:36:50, Ken Russell wrote:
> > Yang, Yunchao, Qiankun: could you please apply and build this patch locally
and
> > see, on an affected Mesa version, whether it still solves the problem of
Google
> > Maps' labels not rendering correctly?
> > 
> > zmo, cwallez: PTAL, but I would like to hold off CQ'ing this until it's
known
> > that it actually works.
> lgtm

lgtm, an alternative would be to revert my CL and just remove the two lines in
this one, it depends on if we want to keep the flag to make it easy for people
to test against the old behavior.

[Ken Russell (switch to Gerrit), 2016-11-04 18:19:05]

On 2016/11/04 18:03:16, Corentin Wallez wrote:
> On 2016/11/04 at 17:48:25, zmo wrote:
> > On 2016/11/04 17:36:50, Ken Russell wrote:
> > > Yang, Yunchao, Qiankun: could you please apply and build this patch
locally
> and
> > > see, on an affected Mesa version, whether it still solves the problem of
> Google
> > > Maps' labels not rendering correctly?
> > > 
> > > zmo, cwallez: PTAL, but I would like to hold off CQ'ing this until it's
> known
> > > that it actually works.
> > lgtm
> 
> lgtm, an alternative would be to revert my CL and just remove the two lines in
> this one, it depends on if we want to keep the flag to make it easy for people
> to test against the old behavior.

We definitely need to keep the driver bug workaround and might want to extend it
to other platforms in the future.

[Ken Russell (switch to Gerrit), 2016-11-04 22:48:11]

Yang just replied in
https://bugs.chromium.org/p/chromium/issues/detail?id=659030#c15 that this
solves the problem. CQ'ing.

[Ken Russell (switch to Gerrit), 2016-11-04 22:48:15]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 01:16:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-05 01:19:27]

Description was changed from

==========
Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Compatibility problems have been seen with the 3.1 Core Profile
context.

Remove the earlier device ID-based workarounds, but leave in the code
for the create_default_gl_context workaround.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't use OpenGL context versions between 3.0 and 3.2 on Mesa.

Compatibility problems have been seen with the 3.1 Core Profile
context.

Remove the earlier device ID-based workarounds, but leave in the code
for the create_default_gl_context workaround.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/79d13b8fa8301665906bfdd7de27643c8b411502
Cr-Commit-Position: refs/heads/master@{#430114}
==========

[commit-bot: I haz the power, 2016-11-05 01:19:28]

Patchset 1 (id:??) landed as
https://crrev.com/79d13b8fa8301665906bfdd7de27643c8b411502
Cr-Commit-Position: refs/heads/master@{#430114}