Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: test/mjsunit/wasm/import-memory.js

Issue 2471883003: [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (Closed)
Patch Set: Rebase, add Dcheck Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-wasm 5 // Flags: --expose-wasm
6 6
7 load("test/mjsunit/wasm/wasm-constants.js"); 7 load("test/mjsunit/wasm/wasm-constants.js");
8 load("test/mjsunit/wasm/wasm-module-builder.js"); 8 load("test/mjsunit/wasm/wasm-module-builder.js");
9 9
10 (function TestOne() { 10 (function TestOne() {
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 .exportFunc(); 192 .exportFunc();
193 builder.addImportedMemory("mine"); 193 builder.addImportedMemory("mine");
194 let instance = builder.instantiate({mine: memory}); 194 let instance = builder.instantiate({mine: memory});
195 function grow(pages) { return instance.exports.grow(pages); } 195 function grow(pages) { return instance.exports.grow(pages); }
196 assertEquals(2, grow(3)); 196 assertEquals(2, grow(3));
197 assertEquals(5*kPageSize, memory.buffer.byteLength); 197 assertEquals(5*kPageSize, memory.buffer.byteLength);
198 assertEquals(5, grow(5)); 198 assertEquals(5, grow(5));
199 assertEquals(10*kPageSize, memory.buffer.byteLength); 199 assertEquals(10*kPageSize, memory.buffer.byteLength);
200 assertThrows(() => memory.grow(1)); 200 assertThrows(() => memory.grow(1));
201 })(); 201 })();
202
203 (function TestMemoryGrowWebAssemblyInstances() {
204 print("TestMemoryGrowWebAssemblyInstances");
205 let memory = new WebAssembly.Memory({initial: 1, maximum: 15});
206 var builder = new WasmModuleBuilder();
207 builder.addMemory(1,1, false);
208 builder.addFunction("mem_size", kSig_i_v)
209 .addBody([kExprMemorySize, kMemoryZero])
210 .exportAs("mem_size");
211 builder.addFunction("grow", kSig_i_i)
212 .addBody([kExprGetLocal, 0, kExprGrowMemory, kMemoryZero])
213 .exportFunc();
214 var module = new WebAssembly.Module(builder.toBuffer());
215 var instances = [];
216 for (var i = 0; i < 6; i++) {
217 instances.push(new WebAssembly.Instance(module, null, memory));
218 }
219 function verify_mem_size(expected_pages) {
220 assertEquals(expected_pages*kPageSize, memory.buffer.byteLength);
221 for (var i = 0; i < 6; i++) {
222 assertEquals(expected_pages, instances[i].exports.mem_size());
223 }
224 }
225
226 // Verify initial memory size
227 verify_mem_size(1);
228
229 // Verify memory size with interleaving calls to Memory.grow,
230 // GrowMemory opcode.
231 var current_mem_size = 1;
232 for (var i = 0; i < 5; i++) {
233 function grow(pages) { return instances[i].exports.grow(pages); }
234 assertEquals(current_mem_size, memory.grow(1));
235 verify_mem_size(++current_mem_size);
236 assertEquals(current_mem_size, instances[i].exports.grow(1));
237 verify_mem_size(++current_mem_size);
238 }
239
240 assertThrows(() => memory.grow(5));
241 })();
242
243 (function TestImportedMemoryGrowMultipleInstances() {
244 print("TestImportMemoryMultipleInstances");
245 let memory = new WebAssembly.Memory({initial: 5, maximum: 100});
246 var builder = new WasmModuleBuilder();
247 builder.addImportedMemory("imported_mem");
248 builder.addFunction("mem_size", kSig_i_v)
249 .addBody([kExprMemorySize, kMemoryZero])
250 .exportFunc();
251 builder.addFunction("grow", kSig_i_i)
252 .addBody([kExprGetLocal, 0, kExprGrowMemory, kMemoryZero])
253 .exportFunc();
254 var instances = [];
255 for (var i = 0; i < 5; i++) {
256 instances.push(builder.instantiate({imported_mem: memory}));
257 }
258 function grow_instance_0(pages) { return instances[0].exports.grow(pages); }
259 function grow_instance_1(pages) { return instances[1].exports.grow(pages); }
260 function grow_instance_2(pages) { return instances[2].exports.grow(pages); }
261 function grow_instance_3(pages) { return instances[3].exports.grow(pages); }
262 function grow_instance_4(pages) { return instances[4].exports.grow(pages); }
263
264 function verify_mem_size(expected_pages) {
265 assertEquals(expected_pages*kPageSize, memory.buffer.byteLength);
266 for (var i = 0; i < 5; i++) {
267 assertEquals(expected_pages, instances[i].exports.mem_size());
268 }
269 }
270
271 // Verify initial memory size
272 verify_mem_size(5);
273
274 // Grow instance memory and buffer memory out of order and verify memory is
275 // updated correctly.
276 assertEquals(5, grow_instance_0(7));
277 verify_mem_size(12);
278
279 assertEquals(12, memory.grow(4));
280 verify_mem_size(16);
281
282 assertEquals(16, grow_instance_4(1));
283 verify_mem_size(17);
284
285 assertEquals(17, grow_instance_1(6));
286 verify_mem_size(23);
287
288 assertEquals(23, grow_instance_3(2));
289 verify_mem_size(25);
290
291 assertEquals(25, memory.grow(10));
292 verify_mem_size(35);
293
294 assertEquals(35, grow_instance_2(15));
295 verify_mem_size(50);
296 assertThrows(() => memory.grow(51));
297 })();
298
299 (function TestExportImportedMemoryGrowMultipleInstances() {
300 // TODO(gdeepti):Exported memory objects currently do not take max_size
301 // into account so this can grow past the maximum specified in the exported
302 // memory object. Assert that growing past maximum for exported objects fails.
303 print("TestExportImportedMemoryGrowMultipleInstances");
304 var instance;
305 {
306 let builder = new WasmModuleBuilder();
307 builder.addMemory(1, 11, true);
308 builder.exportMemoryAs("exported_mem");
309 builder.addFunction("mem_size", kSig_i_v)
310 .addBody([kExprMemorySize, kMemoryZero])
311 .exportFunc();
312 instance = builder.instantiate();
313 }
314 var builder = new WasmModuleBuilder();
315 builder.addImportedMemory("imported_mem");
316 builder.addFunction("mem_size", kSig_i_v)
317 .addBody([kExprMemorySize, kMemoryZero])
318 .exportFunc();
319 builder.addFunction("grow", kSig_i_i)
320 .addBody([kExprGetLocal, 0, kExprGrowMemory, kMemoryZero])
321 .exportFunc();
322 var instances = [];
323 for (var i = 0; i < 10; i++) {
324 instances.push(builder.instantiate({
325 imported_mem: instance.exports.exported_mem}));
326 }
327 function verify_mem_size(expected_pages) {
328 for (var i = 0; i < 10; i++) {
329 assertEquals(expected_pages, instances[i].exports.mem_size());
330 }
331 }
332 var current_mem_size = 1;
333 for (var i = 0; i < 10; i++) {
334 function grow(pages) { return instances[i].exports.grow(pages); }
335 assertEquals(current_mem_size, instances[i].exports.grow(1));
336 verify_mem_size(++current_mem_size);
337 }
338 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698