content/browser/presentation/presentation_type_converters_unittest.cc - Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_type_converters_unittest.cc

Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « content/browser/presentation/presentation_type_converters.h ('k') | content/public/browser/presentation_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_type_converters_unittest.cc

diff --git a/content/browser/presentation/presentation_type_converters_unittest.cc b/content/browser/presentation/presentation_type_converters_unittest.cc

index e3f462363f94ed7bf3bd944943bf6209d6fed8cd..11c6c838b1ebfc92b3e1763eabccab33a1e5133d 100644

--- a/content/browser/presentation/presentation_type_converters_unittest.cc

+++ b/content/browser/presentation/presentation_type_converters_unittest.cc

@@ -12,7 +12,7 @@ namespace content {

TEST(PresentationTypeConvertersTest, PresentationSessionInfo) {

GURL presentation_url("http://www.example.com/");

std::string presentation_id("presentationId");

- PresentationSessionInfo session(presentation_url, presentation_id);

+ PresentationSessionInfo session(presentation_url, presentation_id, false);

blink::mojom::PresentationSessionInfoPtr session_mojo(

blink::mojom::PresentationSessionInfo::From(session));

EXPECT_FALSE(session_mojo.is_null());