Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: content/browser/presentation/presentation_service_impl_unittest.cc

Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_service_impl_unittest.cc
diff --git a/content/browser/presentation/presentation_service_impl_unittest.cc b/content/browser/presentation/presentation_service_impl_unittest.cc
index 73f3dde1d00b56c60105fe3cf9dfe1c974423aad..4592ccff5e3500c71d138a340658076b3dad9a19 100644
--- a/content/browser/presentation/presentation_service_impl_unittest.cc
+++ b/content/browser/presentation/presentation_service_impl_unittest.cc
@@ -485,14 +485,14 @@ TEST_F(PresentationServiceImplTest, SetDefaultPresentationUrls) {
OnDefaultSessionStarted(SessionInfoEquals(ByRef(session_info))))
.WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
EXPECT_CALL(mock_delegate_, ListenForConnectionStateChange(_, _, _, _));
- callback.Run(
- content::PresentationSessionInfo(presentation_url2_, kPresentationId));
+ callback.Run(content::PresentationSessionInfo(presentation_url2_,
+ kPresentationId, false));
run_loop.Run();
}
TEST_F(PresentationServiceImplTest, ListenForConnectionStateChange) {
content::PresentationSessionInfo connection(presentation_url1_,
- kPresentationId);
+ kPresentationId, false);
content::PresentationConnectionStateChangedCallback state_changed_cb;
EXPECT_CALL(mock_delegate_, ListenForConnectionStateChange(_, _, _, _))
.WillOnce(SaveArg<3>(&state_changed_cb));
@@ -517,7 +517,7 @@ TEST_F(PresentationServiceImplTest, ListenForConnectionStateChange) {
TEST_F(PresentationServiceImplTest, ListenForConnectionClose) {
content::PresentationSessionInfo connection(presentation_url1_,
- kPresentationId);
+ kPresentationId, false);
content::PresentationConnectionStateChangedCallback state_changed_cb;
EXPECT_CALL(mock_delegate_, ListenForConnectionStateChange(_, _, _, _))
.WillOnce(SaveArg<3>(&state_changed_cb));
@@ -572,7 +572,8 @@ TEST_F(PresentationServiceImplTest, StartSessionSuccess) {
EXPECT_CALL(mock_delegate_, ListenForConnectionStateChange(_, _, _, _))
.Times(1);
- success_cb.Run(PresentationSessionInfo(presentation_url1_, kPresentationId));
+ success_cb.Run(
+ PresentationSessionInfo(presentation_url1_, kPresentationId, false));
SaveQuitClosureAndRunLoop();
}
@@ -606,7 +607,8 @@ TEST_F(PresentationServiceImplTest, JoinSessionSuccess) {
EXPECT_CALL(mock_delegate_, ListenForConnectionStateChange(_, _, _, _))
.Times(1);
- success_cb.Run(PresentationSessionInfo(presentation_url1_, kPresentationId));
+ success_cb.Run(
+ PresentationSessionInfo(presentation_url1_, kPresentationId, false));
SaveQuitClosureAndRunLoop();
}

Powered by Google App Engine
This is Rietveld 408576698