chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc - Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

index ae7df101c08efc0fda7d0b69450f3c2ae0c2083d..d8bb1ff72288dcc8f37f49eb795b6d9c510bce5a 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

@@ -411,7 +411,7 @@ TEST_F(PresentationServiceDelegateImplTest, ListenForConnnectionStateChange) {

base::Bind(&MockPresentationConnectionStateChangedCallback::Run,

base::Unretained(&mock_callback));

content::PresentationSessionInfo connection(presentation_url1_,

- kPresentationId);

+ kPresentationId, false);

EXPECT_CALL(router_, OnAddPresentationConnectionStateChangedCallbackInvoked(

Equals(callback)));

delegate_impl_->ListenForConnectionStateChange(render_process_id, routing_id,