chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc - Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

Issue 2471883002: [Presentation API] (1st) (1-UA) Add is_offscreen_presentation attribute to MediaRouter (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_route.h ('K') | « chrome/browser/media/router/mojo/media_router.mojom ('k') | chrome/browser/media/router/mojo/media_router_type_converters.cc » ('j') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

index b6abe14f2937e0f0f0ebda4977ec19da568fc9ee..73b7b727461d830a6605c42609796f6d1cbd40b1 100644

--- a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

@@ -1084,8 +1084,8 @@ TEST_F(MediaRouterMojoImplTest, PresentationConnectionStateChangedCallback) {

MediaRoute::Id route_id("route-id");

const GURL presentation_url("http://www.example.com/presentation.html");

const std::string kPresentationId("pid");

- content::PresentationSessionInfo connection(presentation_url,

- kPresentationId);

+ content::PresentationSessionInfo connection(presentation_url, kPresentationId,

+ false);

MockPresentationConnectionStateChangedCallback callback;

std::unique_ptr<PresentationConnectionStateSubscription> subscription =

router()->AddPresentationConnectionStateChangedCallback(