Remove MediaStreamTrack.getSources().

Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710, 388194
Committed: https://crrev.com/3ea42b21339ebf028e0ff6e368ca60d463386dd2
Cr-Commit-Position: refs/heads/master@{#429745}

[Guido Urdaneta, 2016-11-02 16:12:34]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 16:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-11-02 16:32:55]

Description was changed from

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194
==========

to

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194
==========

[Guido Urdaneta, 2016-11-02 16:44:04]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 16:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-11-02 17:08:07]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org, rbyers@chromium.org

[Guido Urdaneta, 2016-11-02 17:11:17]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2016-11-02 17:12:58]

rbyers@chromium.org: please review changes in components/test_runner and
third_party/WebKit

hbos@chromium.org: please review changes in content/renderer/media,
content/test/data/media, extensions/test and chrome/test

[Rick Byers, 2016-11-02 17:34:51]

On 2016/11/02 17:12:58, Guido Urdaneta wrote:
> mailto:rbyers@chromium.org: please review changes in components/test_runner
and
> third_party/WebKit

test_runner and WebKit LGTM
 
> mailto:hbos@chromium.org: please review changes in content/renderer/media,
> content/test/data/media, extensions/test and chrome/test

[Guido Urdaneta, 2016-11-02 17:54:23]

rbyers: forgot to remove from UseCounter.h and Deprecation.cpp in the original
PS. Can you take a quick look at PS2?

[Rick Byers, 2016-11-02 17:57:28]

On 2016/11/02 17:54:23, Guido Urdaneta wrote:
> rbyers: forgot to remove from UseCounter.h and Deprecation.cpp in the original
> PS. Can you take a quick look at PS2?

Still LGTM.  Thanks for checking.

[hbos_chromium, 2016-11-03 10:25:40]

content/renderer/media
content/test/data/media
extensions/test
chrome/test

LGTM % comments

https://codereview.chromium.org/2471803002/diff/40001/chrome/test/data/webrtc...
File chrome/test/data/webrtc/media_devices.js (right):

https://codereview.chromium.org/2471803002/diff/40001/chrome/test/data/webrtc...
chrome/test/data/webrtc/media_devices.js:17: }
This change affects this code, right?
https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_getme...

It should be updated not to support the getSources path and the two disabled
unittests, DISABLED_GetMediaDevicesEqualsGetSourcesWithoutAccess and
DISABLED_GetMediaDevicesEqualsGetSourcesWithAccess should be removed.
https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_getme...

https://codereview.chromium.org/2471803002/diff/40001/content/test/data/media...
File content/test/data/media/getusermedia.html (right):

https://codereview.chromium.org/2471803002/diff/40001/content/test/data/media...
content/test/data/media/getusermedia.html:24: 'facing': ""
I don't think this is used, can 'facing' be removed from the results instead of
setting it to an empty string?

[Guido Urdaneta, 2016-11-03 11:41:10]

https://codereview.chromium.org/2471803002/diff/40001/chrome/test/data/webrtc...
File chrome/test/data/webrtc/media_devices.js (right):

https://codereview.chromium.org/2471803002/diff/40001/chrome/test/data/webrtc...
chrome/test/data/webrtc/media_devices.js:17: }
On 2016/11/03 10:25:40, hbos_chromium wrote:
> This change affects this code, right?
>
https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_getme...
> 
> It should be updated not to support the getSources path and the two disabled
> unittests, DISABLED_GetMediaDevicesEqualsGetSourcesWithoutAccess and
> DISABLED_GetMediaDevicesEqualsGetSourcesWithAccess should be removed.
>
https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_getme...

Nice catch. I'll address the issues with this test in a separate CL. Since those
tests are disabled, it doesn't interfere with this removal.

https://codereview.chromium.org/2471803002/diff/40001/content/test/data/media...
File content/test/data/media/getusermedia.html (right):

https://codereview.chromium.org/2471803002/diff/40001/content/test/data/media...
content/test/data/media/getusermedia.html:24: 'facing': ""
On 2016/11/03 10:25:40, hbos_chromium wrote:
> I don't think this is used, can 'facing' be removed from the results instead
of
> setting it to an empty string?

I'll keep it for compatibility for now.

[Guido Urdaneta, 2016-11-03 11:41:16]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-11-03 11:41:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-11-03 12:51:56]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-11-03 12:51:56]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2471803002/#ps60001
(title: "Update test expectations")

[commit-bot: I haz the power, 2016-11-03 12:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 14:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:43:14]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Guido Urdaneta, 2016-11-03 15:06:36]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-11-03 15:06:36]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2471803002/#ps80001
(title: "Fix platform-specific expectations file")

[commit-bot: I haz the power, 2016-11-03 15:06:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:09:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Guido Urdaneta, 2016-11-03 20:15:07]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:15:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 00:57:03]

Description was changed from

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194
==========

to

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194
==========

[commit-bot: I haz the power, 2016-11-04 00:57:05]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-04 01:02:05]

Description was changed from

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194
==========

to

==========
Remove MediaStreamTrack.getSources().

Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY

BUG=649710,388194

Committed: https://crrev.com/3ea42b21339ebf028e0ff6e368ca60d463386dd2
Cr-Commit-Position: refs/heads/master@{#429745}
==========

[commit-bot: I haz the power, 2016-11-04 01:02:09]

Patchset 4 (id:??) landed as
https://crrev.com/3ea42b21339ebf028e0ff6e368ca60d463386dd2
Cr-Commit-Position: refs/heads/master@{#429745}

[brianderson, 2016-11-08 22:27:24]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2481263004/ by brianderson@chromium.org.

The reason for reverting is: Broke some test metrics. See
http://crbug.com/662414..