Modifies how Arc's throttle handles redirections

Modifies how Arc's throttle handles redirections

Since we want to handle navigations going from https to http we need to
enforce having a Referrer(), we call it |starting_gurl_|. This will
allow us to know where the navigation started and fire up the intent
picker.

This also modifies the way we treat redirections within the same
navigation throttle object. Since we now enforce having a starting GURL
we are not discarding as many throttles via ShouldOverrideUrlLoading(),
which previously discarded a throttle just because it didn't contain a
referrer.

BUG=654941
TEST=Check the repro info on the bug, also manually tested with
youtube link

[djacobo_, 2016-11-03 17:45:15]

Description was changed from

==========
Modifies how Arc's throttle handles redirections

Since we want to handle navigations going from https to http we need to
enforce having a Referrer(), we call it |starting_gurl_|. This will
allow us to know where the navigation started and fire up the intent
picker.

This also modifies the way we treat redirections within the same
navigation throttle object. Since we now enforce having a starting GURL
we are not discarding as many throttles via ShouldOverrideUrlLoading(),
which previously discarded a throttle just because it didn't contain a
referrer.

BUG=654941
TEST=Check the repro info on the bug, also manually tested with
youtube link
==========

to

==========
Modifies how Arc's throttle handles redirections

Since we want to handle navigations going from https to http we need to
enforce having a Referrer(), we call it |starting_gurl_|. This will
allow us to know where the navigation started and fire up the intent
picker.

This also modifies the way we treat redirections within the same
navigation throttle object. Since we now enforce having a starting GURL
we are not discarding as many throttles via ShouldOverrideUrlLoading(),
which previously discarded a throttle just because it didn't contain a
referrer.

BUG=654941
TEST=Check the repro info on the bug, also manually tested with
youtube link
==========

[djacobo_, 2016-11-03 17:45:15]

djacobo@google.com changed reviewers:
+ yusukes@chromium.org

[djacobo_, 2016-11-03 17:45:56]

PTAL, already run unit_tests and did some manual testing

[Yusuke Sato, 2016-11-03 19:57:11]

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_navigation_throttle.cc (right):

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_navigation_throttle.cc:141: // We must not
handle navigations started from the context menu.
Please rebase once I finish landing the first one.

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_navigation_throttle.cc:172: GURL
ArcNavigationThrottle::GetStartingGURL() const {
Can you comment which line is different?

[djacobo_, 2016-11-03 20:22:01]

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_navigation_throttle.cc (right):

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_navigation_throttle.cc:141: // We must not
handle navigations started from the context menu.
On 2016/11/03 19:57:11, Yusuke Sato wrote:
> Please rebase once I finish landing the first one.

Done.

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_navigation_throttle.cc:172: GURL
ArcNavigationThrottle::GetStartingGURL() const {
On 2016/11/03 19:57:11, Yusuke Sato wrote:
> Can you comment which line is different?

Oh OK didn't see that, let me add a comment.

[Yusuke Sato, 2016-11-03 20:27:31]

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_navigation_throttle.cc (right):

https://codereview.chromium.org/2471783005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_navigation_throttle.cc:172: GURL
ArcNavigationThrottle::GetStartingGURL() const {
On 2016/11/03 20:22:01, djacobo wrote:
> On 2016/11/03 19:57:11, Yusuke Sato wrote:
> > Can you comment which line is different?
> 
> Oh OK didn't see that, let me add a comment.

Oh sorry I meant comment on rietveld (not code comment) but either is fine.  The
merge process for this file will always be manual because of the directory
change and the additional code comment won't make it worse.

[Yusuke Sato, 2016-11-03 20:41:38]

lgtm, landing PS #4

[Yusuke Sato, 2016-11-03 21:20:18]

done
https://chromium.googlesource.com/chromium/src.git/+/827d3e0f0234f4fdec8dfc47...