Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2471733002: Fix for client_engine_integration.py (Closed)

Created:
4 years, 1 month ago by xingliu
Modified:
4 years, 1 month ago
CC:
perumaal, shenghuazhang, chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for client_engine_integration.py Client_engine_integration script detects the engine port from a log in blimp_engine_session.cc, we have a patch removed that log so the script cannot start the engine, add it back to make it works. BUG=NONE Committed: https://crrev.com/5428ff21330927cdf951507811f24858d7d1336e Cr-Commit-Position: refs/heads/master@{#429345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M blimp/engine/session/blimp_engine_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xingliu
Fix the client_engine_integration script. So we can connect to local engine again. By the way, ...
4 years, 1 month ago (2016-11-02 02:41:19 UTC) #2
David Trainor- moved to gerrit
lgtm, but we should probably look into manually specifying the port.
4 years, 1 month ago (2016-11-02 17:42:56 UTC) #3
xingliu
On 2016/11/02 17:42:56, David Trainor (OOO to oct 31) wrote: > lgtm, but we should ...
4 years, 1 month ago (2016-11-02 17:50:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471733002/1
4 years, 1 month ago (2016-11-02 17:51:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 18:18:05 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:23:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5428ff21330927cdf951507811f24858d7d1336e
Cr-Commit-Position: refs/heads/master@{#429345}

Powered by Google App Engine
This is Rietveld 408576698