Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(95)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: extensions/browser/api/networking_private/DEPS
Issue
2471723002
:
chromeos: networkingPrivate: Set active proxy values (Closed)
Patch Set: Fix test expectations
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
chromeos/network/network_state_handler.h
chromeos/network/network_state_handler.cc
chromeos/network/proxy/ui_proxy_config_service.cc
components/onc/onc_constants.h
components/onc/onc_constants.cc
extensions/browser/api/networking_private/DEPS
extensions/browser/api/networking_private/networking_private_chromeos.h
extensions/browser/api/networking_private/networking_private_chromeos.cc
View unified diff
|
Download patch
« no previous file with comments
|
« components/onc/onc_constants.cc
('k') |
extensions/browser/api/networking_private/networking_private_chromeos.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+components/onc",
2 "+components/onc",
3
"+components/proxy_config",
3 "+components/wifi",
4 "+components/wifi",
4 "+chromeos",
5 "+chromeos",
5 "+dbus",
6 "+dbus",
6 "+third_party/cros_system_api"
7 "+third_party/cros_system_api"
7 ]
8 ]
OLD
NEW
« no previous file with comments
|
« components/onc/onc_constants.cc
('k') |
extensions/browser/api/networking_private/networking_private_chromeos.h »
('j') |
no next file with comments »
Issue 2471723002: chromeos: networkingPrivate: Set active proxy values (Closed)
Created 4 years, 1 month ago by stevenjb
Modified 4 years, 1 month ago
Reviewers: michaelpg, emaxx
Base URL:
Comments: 27
This is Rietveld
408576698
Chromium Code Reviews
Issue 2471723002:
chromeos: networkingPrivate: Set active proxy values (Closed)
