Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471713002:
Add Blimp Linux dbg to the CQ permanently (Closed)
DescriptionAdd Blimp Linux dbg to the CQ permanently
I reviewed a few links related to the builder and all looks
good as far as I can tell since raised to 100% yesterday.
chrome-eng-review@ stated they have no concerns, so
removing experiment percentage to make this a real part of
the CQ moving forward.
BUG=618350
R=tandrii@chromium.org
NOTRY=True
Committed: https://crrev.com/df9570c065e6600e0b228ada1d92519f4a90988e
Cr-Commit-Position: refs/heads/master@{#429601}
Patch Set 1 #
Messages
Total messages: 23 (10 generated)
PTAL.
The CQ bit was checked by amineer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
tandrii@chromium.org changed reviewers: + sergeyberezin@chromium.org
We had a spike of everything yesterday, so it's hard to know yet impact of this builder on capacity. +sergeyberezin@ can you PTAL?
linux_cq pool is approaching its limit, actually: https://goto.google.com/cpxdo But blimp_linux_dbg is only taking ~10-11 bots out of 483 total, so it's a drop in a bucket. I'd say we can go ahead with this, but someone separately should look into the capacity of this pool.
lgtm
Description was changed from ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org ========== to ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True ==========
tandrii@chromium.org changed reviewers: + phajdan.jr@chromium.org
On 2016/11/03 01:25:23, Sergey Berezin wrote: > linux_cq pool is approaching its limit, actually: https://goto.google.com/cpxdo > > But blimp_linux_dbg is only taking ~10-11 bots out of 483 total, so it's a drop > in a bucket. I'd say we can go ahead with this, but someone separately should > look into the capacity of this pool. +Pawel can you please look at this (if not already)
The CQ bit was checked by amineer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True ========== to ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True ========== to ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True Committed: https://crrev.com/df9570c065e6600e0b228ada1d92519f4a90988e Cr-Commit-Position: refs/heads/master@{#429601} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/df9570c065e6600e0b228ada1d92519f4a90988e Cr-Commit-Position: refs/heads/master@{#429601}
Message was sent while issue was closed.
Description was changed from ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True Committed: https://crrev.com/df9570c065e6600e0b228ada1d92519f4a90988e Cr-Commit-Position: refs/heads/master@{#429601} ========== to ========== Add Blimp Linux dbg to the CQ permanently I reviewed a few links related to the builder and all looks good as far as I can tell since raised to 100% yesterday. chrome-eng-review@ stated they have no concerns, so removing experiment percentage to make this a real part of the CQ moving forward. BUG=618350 R=tandrii@chromium.org NOTRY=True Committed: https://crrev.com/df9570c065e6600e0b228ada1d92519f4a90988e Cr-Commit-Position: refs/heads/master@{#429601} ==========
Message was sent while issue was closed.
On 2016/11/03 13:28:15, tandrii(chromium) wrote: > On 2016/11/03 01:25:23, Sergey Berezin wrote: > > linux_cq pool is approaching its limit, actually: > https://goto.google.com/cpxdo > > > > But blimp_linux_dbg is only taking ~10-11 bots out of 483 total, so it's a > drop > > in a bucket. I'd say we can go ahead with this, but someone separately should > > look into the capacity of this pool. > > +Pawel can you please look at this (if not already) I used to. This now seems related to things Andy's team is working on. Andy, I'd be happy to help, but wanted to check with you first.
Message was sent while issue was closed.
andybons@chromium.org changed reviewers: + andybons@chromium.org
Message was sent while issue was closed.
Message was sent while issue was closed.
On 2016/11/03 17:38:24, Bons wrote: Go ahead. No objections. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
