Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2471653004: Include expected outputs in Polymer UI (Closed)

Created:
4 years, 1 month ago by aludwin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hide "expected outputs" row when it would be empty; fix "more details" display #

Patch Set 3 : Remove useless function (review for PS2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 2 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aludwin
This is the Polymer equivalent of https://codereview.chromium.org/2465273002/. I tested it on my local server and ...
4 years, 1 month ago (2016-11-02 15:10:51 UTC) #2
kjlubick
https://codereview.chromium.org/2471653004/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2471653004/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode255 appengine/swarming/ui/res/imp/taskpage/task-page.html:255: <tr> What does this show if there are no ...
4 years, 1 month ago (2016-11-02 15:21:41 UTC) #4
aludwin
https://codereview.chromium.org/2471653004/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2471653004/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode255 appengine/swarming/ui/res/imp/taskpage/task-page.html:255: <tr> On 2016/11/02 15:21:41, kjlubick wrote: > What does ...
4 years, 1 month ago (2016-11-02 16:23:29 UTC) #5
aludwin
4 years, 1 month ago (2016-11-02 16:30:54 UTC) #6
KevinL
lgtm, make sure to re-run make vulcanize before committing.
4 years, 1 month ago (2016-11-02 16:36:47 UTC) #8
aludwin
On 2016/11/02 16:36:47, KevinL wrote: > lgtm, make sure to re-run make vulcanize before committing. ...
4 years, 1 month ago (2016-11-02 17:36:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471653004/40001
4 years, 1 month ago (2016-11-02 17:36:29 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:40:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/22e1f420f5f70bc0d73d165ef1b92e7474b78524

Powered by Google App Engine
This is Rietveld 408576698