Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2471653002: Check that XOpenDevice() returns valid device_id. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org, mfomitchev
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that XOpenDevice() returns valid device_id. XOpenDevice() is sometimes returning a non-null XDevice* but the contents are garbage. This shouldn't be happening but for now we can check if the device_id is correct. If not, we exit early to avoid a crash from X BadDevice error. BUG=659261 Committed: https://crrev.com/c32a70410b6c23d686dce57bd72080f43a3e5a60 Cr-Commit-Position: refs/heads/master@{#429199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kylechar
4 years, 1 month ago (2016-11-01 21:03:49 UTC) #2
sadrul
lgtm
4 years, 1 month ago (2016-11-02 01:26:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471653002/1
4 years, 1 month ago (2016-11-02 02:52:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 03:57:33 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 04:02:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c32a70410b6c23d686dce57bd72080f43a3e5a60
Cr-Commit-Position: refs/heads/master@{#429199}

Powered by Google App Engine
This is Rietveld 408576698