ash/wm/shutdown_client_proxy.cc - Issue 2471643002: mash: remove the LockStateControllerDelegate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/wm/shutdown_client_proxy.cc

Issue 2471643002: mash: remove the LockStateControllerDelegate. (Closed)

Patch Set: Add bug links + modify other overlay.json file. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ash/wm/shutdown_client_proxy.h"

	6

	7 #include "ash/public/interfaces/shutdown.mojom.h"

	8 #include "services/service_manager/public/cpp/connector.h"

	9

	10 namespace ash {

	11

	12 ShutdownClientProxy::ShutdownClientProxy(service_manager::Connector* connector)

	13 : connector_(connector) {}
	James Cook 2016/11/02 20:20:03 nit: DCHECK connector_ (makes the parameter nullab nit: DCHECK connector_ (makes the parameter nullability self-documenting) Elliot Glaysher 2016/11/02 21:45:16 Done. Show quoted text On 2016/11/02 20:20:03, James Cook wrote: > nit: DCHECK connector_ (makes the parameter nullability self-documenting) Done. Elliot Glaysher 2016/11/02 22:20:47 Reverted this one hunk. Breaks tests. Show quoted text On 2016/11/02 21:45:16, Elliot Glaysher wrote: > On 2016/11/02 20:20:03, James Cook wrote: > > nit: DCHECK connector_ (makes the parameter nullability self-documenting) > > Done. Reverted this one hunk. Breaks tests.
	14

	15 ShutdownClientProxy::~ShutdownClientProxy() {}

	16

	17 void ShutdownClientProxy::RequestShutdown() {

	18 mojom::ShutdownClientPtr client;

	19 connector_->ConnectToInterface("service:content_browser", &client);

	20 client->RequestShutdown();

	21 }

	22

	23 } // namespace ash

OLD	NEW