Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: chrome/browser/banners/app_banner_manager_browsertest.cc

Issue 2471633003: Disable WebAppBannerCreatedDirectMultipleLargerTotal test due to flakiness. (Closed)
Patch Set: Fix incorrect defines Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_manager_browsertest.cc b/chrome/browser/banners/app_banner_manager_browsertest.cc
index 1cd312703051dc08fa3418eb3aae8b696584567f..3db23e96bee769cf854a1594e671eb4d505af81d 100644
--- a/chrome/browser/banners/app_banner_manager_browsertest.cc
+++ b/chrome/browser/banners/app_banner_manager_browsertest.cc
@@ -206,8 +206,16 @@ IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
ui::PAGE_TRANSITION_GENERATED, 3, SHOWING_WEB_APP_BANNER, true);
}
+// Disabled due to flakiness: crbug.com/661511.
+#if defined(OS_LINUX) || defined(OS_WIN)
+#define MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal \
+ DISABLED_WebAppBannerCreatedDirectMultipleLargerTotal
+#else
+#define MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal \
+ WebAppBannerCreatedDirectMultipleLargerTotal
+#endif
IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
- WebAppBannerCreatedDirectMultipleLargerTotal) {
+ MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal) {
AppBannerSettingsHelper::SetEngagementWeights(0.5, 1);
AppBannerSettingsHelper::SetTotalEngagementToTrigger(3);
RunBannerTest("/banners/manifest_test_page.html",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698