Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2471623008: Use Chromium's USB descriptor parser on macOS and Windows. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Chromium's USB descriptor parser on macOS and Windows. This change adds two new functions to libusb's public interface that allow Chromium to get access to the unparsed USB descriptors. These can then be passed to the new descriptor parser that is used on Android, Chrome OS and Linux. BUG=650606 Committed: https://crrev.com/50b206c50187f592efed9ed44fc8aba64c47e1d9 Cr-Commit-Position: refs/heads/master@{#430142}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -69 lines) Patch
M device/usb/usb_device_impl.cc View 3 chunks +13 lines, -69 lines 0 comments Download
M third_party/libusb/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libusb/src/libusb/descriptor.c View 1 2 chunks +91 lines, -0 lines 0 comments Download
M third_party/libusb/src/libusb/libusb.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 1 month ago (2016-11-04 20:09:33 UTC) #4
juncai
LGTM with nit. https://codereview.chromium.org/2471623008/diff/1/third_party/libusb/src/libusb/descriptor.c File third_party/libusb/src/libusb/descriptor.c (right): https://codereview.chromium.org/2471623008/diff/1/third_party/libusb/src/libusb/descriptor.c#newcode578 third_party/libusb/src/libusb/descriptor.c:578: unsigned char *buf = NULL; nit: ...
4 years, 1 month ago (2016-11-05 01:04:07 UTC) #7
Reilly Grant (use Gerrit)
Remove unused variable.
4 years, 1 month ago (2016-11-05 02:31:25 UTC) #8
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2471623008/diff/1/third_party/libusb/src/libusb/descriptor.c File third_party/libusb/src/libusb/descriptor.c (right): https://codereview.chromium.org/2471623008/diff/1/third_party/libusb/src/libusb/descriptor.c#newcode578 third_party/libusb/src/libusb/descriptor.c:578: unsigned char *buf = NULL; On 2016/11/05 at 01:04:07, ...
4 years, 1 month ago (2016-11-05 02:31:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471623008/20001
4 years, 1 month ago (2016-11-05 02:32:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-05 03:28:37 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 03:30:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50b206c50187f592efed9ed44fc8aba64c47e1d9
Cr-Commit-Position: refs/heads/master@{#430142}

Powered by Google App Engine
This is Rietveld 408576698