|
|
Chromium Code Reviews
Descriptionuse nullptr instead of void* 0 in FontCacheSkiaWin.cpp
0 and nullptr are both existing in FontCacheSkiaWin.cpp.
use only nullptr.
BUG=nobug
R=pdr@chromium.org
Committed: https://crrev.com/b084e0a0eded11ac67ac4b7c19ee61b07b665754
Cr-Commit-Position: refs/heads/master@{#430303}
Patch Set 1 #
Messages
Total messages: 34 (19 generated)
Description was changed from ========== use nullptr instead of void* 0 0 and nullptr are existing all in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=szager@chromium.org ========== to ========== use nullptr instead of void* 0 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=szager@chromium.org ==========
The CQ bit was checked by debugwang@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== use nullptr instead of void* 0 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=szager@chromium.org ========== to ========== use nullptr instead of void* 0 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org ==========
debugwang@tencent.com changed reviewers: + pdr@chromium.org - szager@chromium.org
debugwang@tencent.com changed required reviewers: + pdr@chromium.org
debugwang@tencent.com changed reviewers: + jbroman@chromium.org - pdr@chromium.org
debugwang@tencent.com changed required reviewers: - pdr@chromium.org
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr.
szager@chromium.org changed reviewers: + szager@chromium.org
lgtm
The CQ bit was checked by debugwang@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
debugwang@tencent.com changed reviewers: - szager@chromium.org
using nullptr is more normative
debugwang@tencent.com changed reviewers: + pdr@chromium.org - jbroman@chromium.org
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr.
debugwang@tencent.com changed reviewers: + drott@chromium.org - pdr@chromium.org
0 and nullptr are existing all in FontCacheSkiaWin.cpp. use only nullptr.
debugwang@tencent.com changed reviewers: + mkwst@chromium.org
Hi, mkwst, drott, would you please review this patch?
mkwst@chromium.org changed reviewers: + szager@chromium.org
lgtm LGTM.
Description was changed from ========== use nullptr instead of void* 0 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org ========== to ========== use nullptr instead of void* 0 in FontCacheSkiaWin.cpp 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org ==========
The CQ bit was checked by debugwang@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== use nullptr instead of void* 0 in FontCacheSkiaWin.cpp 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org ========== to ========== use nullptr instead of void* 0 in FontCacheSkiaWin.cpp 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org Committed: https://crrev.com/b084e0a0eded11ac67ac4b7c19ee61b07b665754 Cr-Commit-Position: refs/heads/master@{#430303} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b084e0a0eded11ac67ac4b7c19ee61b07b665754 Cr-Commit-Position: refs/heads/master@{#430303} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
