Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2471623005: use nullptr instead of void* 0 (Closed)

Created:
4 years, 1 month ago by debugwang
Modified:
4 years, 1 month ago
Reviewers:
drott, Mike West, szager1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use nullptr instead of void* 0 in FontCacheSkiaWin.cpp 0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org Committed: https://crrev.com/b084e0a0eded11ac67ac4b7c19ee61b07b665754 Cr-Commit-Position: refs/heads/master@{#430303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 34 (19 generated)
debugwang
4 years, 1 month ago (2016-11-03 03:45:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471623005/1
4 years, 1 month ago (2016-11-03 03:54:45 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-03 03:54:46 UTC) #6
debugwang
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr.
4 years, 1 month ago (2016-11-03 16:33:00 UTC) #12
szager1
lgtm
4 years, 1 month ago (2016-11-03 17:56:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471623005/1
4 years, 1 month ago (2016-11-04 00:12:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/296600)
4 years, 1 month ago (2016-11-04 00:51:06 UTC) #18
debugwang
using nullptr is more normative
4 years, 1 month ago (2016-11-04 02:38:22 UTC) #20
debugwang
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr.
4 years, 1 month ago (2016-11-04 14:19:28 UTC) #22
debugwang
0 and nullptr are existing all in FontCacheSkiaWin.cpp. use only nullptr.
4 years, 1 month ago (2016-11-05 02:09:03 UTC) #24
debugwang
Hi, mkwst, drott, would you please review this patch?
4 years, 1 month ago (2016-11-07 13:31:33 UTC) #26
Mike West
lgtm LGTM.
4 years, 1 month ago (2016-11-07 13:52:52 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471623005/1
4 years, 1 month ago (2016-11-07 13:53:38 UTC) #31
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 17:24:34 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 17:43:59 UTC) #34
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b084e0a0eded11ac67ac4b7c19ee61b07b665754
Cr-Commit-Position: refs/heads/master@{#430303}

Powered by Google App Engine
This is Rietveld 408576698