third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2471623003: Complete layout even if a block needs relayout due to widows or column balancing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2471623003: Complete layout even if a block needs relayout due to widows or column balancing. (Closed)

Patch Set: Getting the flowthread once makes the code slighty prettier. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index 13872c04beff4915d836ee7fc4fdea9c364d41ff..017c4276b22fc5a624707ee36a57430a98458b26 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -477,8 +477,7 @@ class CORE_EXPORT LayoutBlockFlow : public LayoutBlock {

private:

void resetLayout();

- bool layoutBlockFlow(bool relayoutChildren,

- SubtreeLayoutScope&);

+ void layoutBlockFlow(bool relayoutChildren, SubtreeLayoutScope&);

void addOverhangingFloatsFromChildren(LayoutUnit unconstrainedHeight);

void layoutBlockChildren(bool relayoutChildren,

SubtreeLayoutScope&,