Chromium Code Reviews
DescriptionRevert of Add SafeBrowsingNavigationObserver to listen to navigation events (patchset #25 id:720001 of https://codereview.chromium.org/2302913003/ )
Reason for revert:
SPP browsertests are failing.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/48395
../../chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc:488: Failure
Value of: nav_map->size()
Actual: 2
Expected: std::size_t(3)
Which is: 3
Original issue's description:
> Add SafeBrowsingNavigationObserver to listen to navigation events
> happen on all frames.
>
> These navigation events can help safe browsing service identify
> suspicious downloads that intentionally hide their referrers
> and/or landing pages, and report these pieces of info to safe
> browsing backend.
>
> This CL only covers the observing part. More management code
> (e.g. periodically cleanup, actual reporting, etc) will come up
> shortly.
>
> BUG=639467
>
> Committed: https://crrev.com/602009dfabda593406bfd7f5171e8c4183335bf5
> Committed: https://crrev.com/1782326f8a2c81a58136a0475d83f6c1c11db38d
> Cr-Original-Commit-Position: refs/heads/master@{#428865}
> Cr-Commit-Position: refs/heads/master@{#429071}
TBR=creis@chromium.org,nparker@chromium.org,jialiul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639467
Committed: https://crrev.com/e05cceaec5a0be22d382b96202058103344f9649
Cr-Commit-Position: refs/heads/master@{#429099}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|