Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issue 2471623002: Revert of Add SafeBrowsingNavigationObserver to listen to navigation events (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add SafeBrowsingNavigationObserver to listen to navigation events (patchset #25 id:720001 of https://codereview.chromium.org/2302913003/ ) Reason for revert: SPP browsertests are failing. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/48395 ../../chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc:488: Failure Value of: nav_map->size() Actual: 2 Expected: std::size_t(3) Which is: 3 Original issue's description: > Add SafeBrowsingNavigationObserver to listen to navigation events > happen on all frames. > > These navigation events can help safe browsing service identify > suspicious downloads that intentionally hide their referrers > and/or landing pages, and report these pieces of info to safe > browsing backend. > > This CL only covers the observing part. More management code > (e.g. periodically cleanup, actual reporting, etc) will come up > shortly. > > BUG=639467 > > Committed: https://crrev.com/602009dfabda593406bfd7f5171e8c4183335bf5 > Committed: https://crrev.com/1782326f8a2c81a58136a0475d83f6c1c11db38d > Cr-Original-Commit-Position: refs/heads/master@{#428865} > Cr-Commit-Position: refs/heads/master@{#429071} TBR=creis@chromium.org,nparker@chromium.org,jialiul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639467 Committed: https://crrev.com/e05cceaec5a0be22d382b96202058103344f9649 Cr-Commit-Position: refs/heads/master@{#429099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1696 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer.h View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc View 1 chunk +0 lines, -823 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_multi_frame_tests.html View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html View 4 chunks +50 lines, -67 lines 0 comments Download
A chrome/test/data/safe_browsing/download_protection/navigation_observer/safe_page.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Avi (use Gerrit)
Created Revert of Add SafeBrowsingNavigationObserver to listen to navigation events
4 years, 1 month ago (2016-11-01 20:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471623002/1
4 years, 1 month ago (2016-11-01 20:44:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 20:45:57 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 20:48:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e05cceaec5a0be22d382b96202058103344f9649
Cr-Commit-Position: refs/heads/master@{#429099}

Powered by Google App Engine
This is Rietveld 408576698