Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: services/video_capture/video_capture_service.cc

Issue 2471613005: [Mojo Video Capture] Use actual factory instances implementing media::VideoCaptureDeviceFactory (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/video_capture/video_capture_service.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/video_capture_service.h" 5 #include "services/video_capture/video_capture_service.h"
6 6
7 #include "media/capture/video/fake_video_capture_device.h" 7 #include "base/message_loop/message_loop.h"
8 #include "media/capture/video/fake_video_capture_device_factory.h"
9 #include "media/capture/video/video_capture_buffer_pool.h"
10 #include "media/capture/video/video_capture_buffer_tracker.h"
8 #include "media/capture/video/video_capture_jpeg_decoder.h" 11 #include "media/capture/video/video_capture_jpeg_decoder.h"
9 #include "services/service_manager/public/cpp/interface_registry.h" 12 #include "services/service_manager/public/cpp/interface_registry.h"
10 #include "services/video_capture/video_capture_device_factory_impl.h" 13 #include "services/video_capture/device_factory_media_to_mojo_adapter.h"
14 #include "services/video_capture/mock_device_factory.h"
11 15
12 namespace { 16 namespace {
13 static const char kFakeDeviceDisplayName[] = "Fake Video Capture Device";
14 static const char kFakeDeviceId[] = "FakeDeviceId";
15 static const char kFakeModelId[] = "FakeModelId";
16 static const float kFakeCaptureDefaultFrameRate = 20.0f;
17
18 // TODO(chfremer): Replace with an actual decoder factory. 17 // TODO(chfremer): Replace with an actual decoder factory.
19 // https://crbug.com/584797 18 // https://crbug.com/584797
20 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() { 19 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
21 return nullptr; 20 return nullptr;
22 } 21 }
23 22
24 } // anonymous namespace 23 } // anonymous namespace
25 24
26 namespace video_capture { 25 namespace video_capture {
27 26
28 VideoCaptureService::VideoCaptureService() = default; 27 VideoCaptureService::VideoCaptureService() : mock_device_factory_(nullptr) {}
29 28
30 VideoCaptureService::~VideoCaptureService() = default; 29 VideoCaptureService::~VideoCaptureService() = default;
31 30
32 bool VideoCaptureService::OnConnect( 31 bool VideoCaptureService::OnConnect(
33 const service_manager::ServiceInfo& remote_info, 32 const service_manager::ServiceInfo& remote_info,
34 service_manager::InterfaceRegistry* registry) { 33 service_manager::InterfaceRegistry* registry) {
35 registry->AddInterface<mojom::VideoCaptureService>(this); 34 registry->AddInterface<mojom::VideoCaptureService>(this);
36 return true; 35 return true;
37 } 36 }
38 37
(...skipping 12 matching lines...) Expand all
51 void VideoCaptureService::ConnectToFakeDeviceFactory( 50 void VideoCaptureService::ConnectToFakeDeviceFactory(
52 mojom::VideoCaptureDeviceFactoryRequest request) { 51 mojom::VideoCaptureDeviceFactoryRequest request) {
53 LazyInitializeFakeDeviceFactory(); 52 LazyInitializeFakeDeviceFactory();
54 fake_factory_bindings_.AddBinding(fake_device_factory_.get(), 53 fake_factory_bindings_.AddBinding(fake_device_factory_.get(),
55 std::move(request)); 54 std::move(request));
56 } 55 }
57 56
58 void VideoCaptureService::ConnectToMockDeviceFactory( 57 void VideoCaptureService::ConnectToMockDeviceFactory(
59 mojom::VideoCaptureDeviceFactoryRequest request) { 58 mojom::VideoCaptureDeviceFactoryRequest request) {
60 LazyInitializeMockDeviceFactory(); 59 LazyInitializeMockDeviceFactory();
61 mock_factory_bindings_.AddBinding(mock_device_factory_.get(), 60 mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(),
62 std::move(request)); 61 std::move(request));
63 } 62 }
64 63
65 void VideoCaptureService::AddDeviceToMockFactory( 64 void VideoCaptureService::AddDeviceToMockFactory(
66 mojom::MockVideoCaptureDevicePtr device, 65 mojom::MockVideoCaptureDevicePtr device,
67 const media::VideoCaptureDeviceDescriptor& descriptor, 66 const media::VideoCaptureDeviceDescriptor& descriptor,
68 const AddDeviceToMockFactoryCallback& callback) { 67 const AddDeviceToMockFactoryCallback& callback) {
69 LazyInitializeMockDeviceFactory(); 68 LazyInitializeMockDeviceFactory();
70 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor)); 69 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor));
71 callback.Run(); 70 callback.Run();
72 } 71 }
73 72
74 void VideoCaptureService::LazyInitializeDeviceFactory() { 73 void VideoCaptureService::LazyInitializeDeviceFactory() {
75 if (device_factory_) 74 if (device_factory_)
76 return; 75 return;
77 device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>( 76
78 base::Bind(CreateJpegDecoder)); 77 // Create the platform-specific device factory.
78 // Task runner does not seem to actually be used.
79 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory =
80 media::VideoCaptureDeviceFactory::CreateFactory(
81 base::MessageLoop::current()->task_runner());
82
83 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
84 std::move(media_device_factory), base::Bind(CreateJpegDecoder));
79 } 85 }
80 86
81 void VideoCaptureService::LazyInitializeFakeDeviceFactory() { 87 void VideoCaptureService::LazyInitializeFakeDeviceFactory() {
82 if (fake_device_factory_) 88 if (fake_device_factory_)
83 return; 89 return;
84 fake_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>( 90
85 base::Bind(CreateJpegDecoder)); 91 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
86 media::VideoCaptureDeviceDescriptor fake_device_descriptor; 92 base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(),
87 fake_device_descriptor.display_name = kFakeDeviceDisplayName; 93 base::Bind(&CreateJpegDecoder));
88 fake_device_descriptor.device_id = kFakeDeviceId;
89 fake_device_descriptor.model_id = kFakeModelId;
90 fake_device_descriptor.capture_api = media::VideoCaptureApi::UNKNOWN;
91 fake_device_descriptor.transport_type =
92 media::VideoCaptureTransportType::OTHER_TRANSPORT;
93 fake_device_factory_->AddMediaDevice(
94 base::MakeUnique<media::FakeVideoCaptureDevice>(
95 media::FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS,
96 kFakeCaptureDefaultFrameRate),
97 std::move(fake_device_descriptor));
98 } 94 }
99 95
100 void VideoCaptureService::LazyInitializeMockDeviceFactory() { 96 void VideoCaptureService::LazyInitializeMockDeviceFactory() {
101 if (mock_device_factory_) 97 if (mock_device_factory_)
102 return; 98 return;
103 mock_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>( 99
104 base::Bind(CreateJpegDecoder)); 100 auto mock_device_factory = base::MakeUnique<MockDeviceFactory>();
101 // We keep a pointer to the MockDeviceFactory as a member so that we can
102 // invoke its AddMockDevice(). Ownership of the MockDeviceFactory is moved
103 // to the DeviceFactoryMediaToMojoAdapter.
104 mock_device_factory_ = mock_device_factory.get();
105 mock_device_factory_adapter_ =
106 base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
107 std::move(mock_device_factory), base::Bind(&CreateJpegDecoder));
105 } 108 }
106 109
107 } // namespace video_capture 110 } // namespace video_capture
OLDNEW
« no previous file with comments | « services/video_capture/video_capture_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698