Reland of Add Resume logic of Purge+Suspend to TabManager.

Reland of Add Resume logic of Purge+Suspend to TabManager. (patchset #1 id:1 of https://codereview.chromium.org/2470073002/ )

Reason for revert:
Because the change added by the reverted patch is not enabled by default.

Original issue's description:
> Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3 id:60001 of https://codereview.chromium.org/2462513002/ )
>
> Reason for revert:
> Reliably breaks Linux ChromiumOS Tests (1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28780 and Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19523
>
> Original issue's description:
> > Add Resume logic of Purge+Suspend to TabManager.
> >
> > - To avoid breaking web, we need to resume a backgrounded renderer that
> >   was purged and suspended.
> >   (A backgrounded renderer is suspended for 120seconds).
> >   After resumed, the renderer is running for 10 seconds and is purged
> >   and suspended again.
> > - intent-to-implement-and-ship of background renderer's purge +
> >   suspend is
> >   https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
> > - one of the documents attached in the above intent is
> >   https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing
> > - The feature is not enabled by default because
> >   purge-and-suspend-time is 0.
> >
> > BUG=635419
> >
> > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b
> > Cr-Commit-Position: refs/heads/master@{#429222}
>
> TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=635419
>
> Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7
> Cr-Commit-Position: refs/heads/master@{#429237}

TBR=haraken@chromium.org,chrisha@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635419
Committed: https://crrev.com/4435d0191470e3e33d3edfa0594cd9de7102a331
Cr-Commit-Position: refs/heads/master@{#429243}

[tasak, 2016-11-02 09:21:46]

The CQ bit was checked by tasak@google.com

[tasak, 2016-11-02 09:21:46]

Created Reland of Add Resume logic of Purge+Suspend to TabManager.

[commit-bot: I haz the power, 2016-11-02 09:21:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 09:22:55]

Description was changed from

==========
Reland of Add Resume logic of Purge+Suspend to TabManager. (patchset #1 id:1 of
https://codereview.chromium.org/2470073002/ )

Reason for revert:
Because the change added by the reverted patch is not enabled by default.



Original issue's description:
> Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3
id:60001 of https://codereview.chromium.org/2462513002/ )
> 
> Reason for revert:
> Reliably breaks Linux ChromiumOS Tests (1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
and Linux ChromiumOS Tests (dbg)(1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Add Resume logic of Purge+Suspend to TabManager.
> >
> > - To avoid breaking web, we need to resume a backgrounded renderer that
> >   was purged and suspended.
> >   (A backgrounded renderer is suspended for 120seconds).
> >   After resumed, the renderer is running for 10 seconds and is purged
> >   and suspended again.
> > - intent-to-implement-and-ship of background renderer's purge +
> >   suspend is
> >  
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
> > - one of the documents attached in the above intent is
> >  
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
> > - The feature is not enabled by default because
> >   purge-and-suspend-time is 0.
> >
> > BUG=635419
> >
> > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b
> > Cr-Commit-Position: refs/heads/master@{#429222}
> 
> TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=635419
> 
> Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7
> Cr-Commit-Position: refs/heads/master@{#429237}

TBR=haraken@chromium.org,chrisha@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635419
==========

to

==========
Reland of Add Resume logic of Purge+Suspend to TabManager. (patchset #1 id:1 of
https://codereview.chromium.org/2470073002/ )

Reason for revert:
Because the change added by the reverted patch is not enabled by default.



Original issue's description:
> Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3
id:60001 of https://codereview.chromium.org/2462513002/ )
> 
> Reason for revert:
> Reliably breaks Linux ChromiumOS Tests (1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
and Linux ChromiumOS Tests (dbg)(1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Add Resume logic of Purge+Suspend to TabManager.
> >
> > - To avoid breaking web, we need to resume a backgrounded renderer that
> >   was purged and suspended.
> >   (A backgrounded renderer is suspended for 120seconds).
> >   After resumed, the renderer is running for 10 seconds and is purged
> >   and suspended again.
> > - intent-to-implement-and-ship of background renderer's purge +
> >   suspend is
> >  
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
> > - one of the documents attached in the above intent is
> >  
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
> > - The feature is not enabled by default because
> >   purge-and-suspend-time is 0.
> >
> > BUG=635419
> >
> > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b
> > Cr-Commit-Position: refs/heads/master@{#429222}
> 
> TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=635419
> 
> Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7
> Cr-Commit-Position: refs/heads/master@{#429237}

TBR=haraken@chromium.org,chrisha@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635419
==========

[commit-bot: I haz the power, 2016-11-02 09:22:56]

Committed patchset #1 (id:1)

[haraken, 2016-11-02 09:23:33]

Yeah, sorry, your analysis looks correct -- the test is just flaky. LGTM.

[commit-bot: I haz the power, 2016-11-02 09:24:51]

Description was changed from

==========
Reland of Add Resume logic of Purge+Suspend to TabManager. (patchset #1 id:1 of
https://codereview.chromium.org/2470073002/ )

Reason for revert:
Because the change added by the reverted patch is not enabled by default.



Original issue's description:
> Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3
id:60001 of https://codereview.chromium.org/2462513002/ )
> 
> Reason for revert:
> Reliably breaks Linux ChromiumOS Tests (1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
and Linux ChromiumOS Tests (dbg)(1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Add Resume logic of Purge+Suspend to TabManager.
> >
> > - To avoid breaking web, we need to resume a backgrounded renderer that
> >   was purged and suspended.
> >   (A backgrounded renderer is suspended for 120seconds).
> >   After resumed, the renderer is running for 10 seconds and is purged
> >   and suspended again.
> > - intent-to-implement-and-ship of background renderer's purge +
> >   suspend is
> >  
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
> > - one of the documents attached in the above intent is
> >  
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
> > - The feature is not enabled by default because
> >   purge-and-suspend-time is 0.
> >
> > BUG=635419
> >
> > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b
> > Cr-Commit-Position: refs/heads/master@{#429222}
> 
> TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=635419
> 
> Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7
> Cr-Commit-Position: refs/heads/master@{#429237}

TBR=haraken@chromium.org,chrisha@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635419
==========

to

==========
Reland of Add Resume logic of Purge+Suspend to TabManager. (patchset #1 id:1 of
https://codereview.chromium.org/2470073002/ )

Reason for revert:
Because the change added by the reverted patch is not enabled by default.

Original issue's description:
> Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3
id:60001 of https://codereview.chromium.org/2462513002/ )
>
> Reason for revert:
> Reliably breaks Linux ChromiumOS Tests (1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
and Linux ChromiumOS Tests (dbg)(1):
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Original issue's description:
> > Add Resume logic of Purge+Suspend to TabManager.
> >
> > - To avoid breaking web, we need to resume a backgrounded renderer that
> >   was purged and suspended.
> >   (A backgrounded renderer is suspended for 120seconds).
> >   After resumed, the renderer is running for 10 seconds and is purged
> >   and suspended again.
> > - intent-to-implement-and-ship of background renderer's purge +
> >   suspend is
> >  
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
> > - one of the documents attached in the above intent is
> >  
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
> > - The feature is not enabled by default because
> >   purge-and-suspend-time is 0.
> >
> > BUG=635419
> >
> > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b
> > Cr-Commit-Position: refs/heads/master@{#429222}
>
> TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=635419
>
> Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7
> Cr-Commit-Position: refs/heads/master@{#429237}

TBR=haraken@chromium.org,chrisha@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635419

Committed: https://crrev.com/4435d0191470e3e33d3edfa0594cd9de7102a331
Cr-Commit-Position: refs/heads/master@{#429243}
==========

[commit-bot: I haz the power, 2016-11-02 09:24:52]

Patchset 1 (id:??) landed as
https://crrev.com/4435d0191470e3e33d3edfa0594cd9de7102a331
Cr-Commit-Position: refs/heads/master@{#429243}

[kjellander_chromium, 2016-11-02 10:25:40]

lgtm, it seems you're right since bots are now green. I don't see the
correlation with the CLs submitted, but the important thing is that we're back
in a green state. Sorry about the revert - very odd that it was a flake when the
failures seemed so consistent.