Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: src/tracing/tracing-category-observer.h

Issue 2471583004: [Tracing] Make TracingCategoryObserver v8 internal. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/tracing/tracing-category-observer.h
diff --git a/src/tracing/tracing-category-observer.h b/src/tracing/tracing-category-observer.h
index 5e463030bcadb59dbb75a34fb268a144f8d7fd7e..f73dd5926657c024635fb18ab39e60e4236c10c9 100644
--- a/src/tracing/tracing-category-observer.h
+++ b/src/tracing/tracing-category-observer.h
@@ -6,20 +6,31 @@
#define V8_TRACING_TRACING_CATEGORY_OBSERVER_H_
#include "include/v8-platform.h"
-#include "include/v8-tracing.h"
+#include "src/base/macros.h"
namespace v8 {
namespace tracing {
-class TracingCategoryObserverImpl : public TracingCategoryObserver,
- public Platform::TraceStateObserver {
+class TracingCategoryObserver : public Platform::TraceStateObserver {
public:
- TracingCategoryObserverImpl();
- ~TracingCategoryObserverImpl();
+ enum Mode {
+ ENABLED_BY_NATIVE = 1 << 0,
+ ENABLED_BY_TRACING = 1 << 1,
+ };
+
+ static void SetUp();
+ static void TearDown();
// v8::Platform::TraceStateObserver
void OnTraceEnabled() final;
void OnTraceDisabled() final;
+
+ ~TracingCategoryObserver() = default;
alph 2016/11/02 20:18:23 nit: not needed
lpy 2016/11/02 21:52:27 Done.
+
+ private:
+ TracingCategoryObserver() = default;
+
+ DISALLOW_COPY_AND_ASSIGN(TracingCategoryObserver);
};
} // namespace tracing

Powered by Google App Engine
This is Rietveld 408576698