third_party/inspector_protocol/CodeGenerator.py - Issue 2471583003: [inspector] migrate Debugger to new style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/inspector_protocol/CodeGenerator.py

Issue 2471583003: [inspector] migrate Debugger to new style (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/inspector_protocol/CodeGenerator.py

diff --git a/third_party/inspector_protocol/CodeGenerator.py b/third_party/inspector_protocol/CodeGenerator.py

index 408f96154ed11f2dbe5a944fe87cc299ca81c35a..90ce726f9a4773b22604ae1b149f3c8f46d46cc5 100644

--- a/third_party/inspector_protocol/CodeGenerator.py

+++ b/third_party/inspector_protocol/CodeGenerator.py

@@ -330,8 +330,7 @@ def resolve_type(protocol, prop):

def new_style(domain):

- domains = [ "Schema", "Console", "Profiler", "HeapProfiler", "Runtime" ]

- return domain["domain"] in domains

+ return True

def join_arrays(dict, keys):

« no previous file with comments | « src/inspector/v8-inspector-session-impl.cc ('k') | third_party/inspector_protocol/README.v8 » ('j') | no next file with comments »