Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: src/inspector/v8-debugger.h

Issue 2471583003: [inspector] migrate Debugger to new style (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.h
diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h
index 27b169c61f5433fd05d5376b86a4b4b882fca23f..919cffcb11c5690143f2173fcf35099ff9a83f36 100644
--- a/src/inspector/v8-debugger.h
+++ b/src/inspector/v8-debugger.h
@@ -23,7 +23,7 @@ class V8DebuggerAgentImpl;
class V8InspectorImpl;
class V8StackTraceImpl;
-using protocol::ErrorString;
+using protocol::Response;
class V8Debugger {
public:
@@ -53,12 +53,11 @@ class V8Debugger {
void stepOutOfFunction();
void clearStepping();
- bool setScriptSource(const String16& sourceID,
- v8::Local<v8::String> newSource, bool dryRun,
- ErrorString*,
- protocol::Maybe<protocol::Runtime::ExceptionDetails>*,
- JavaScriptCallFrames* newCallFrames,
- protocol::Maybe<bool>* stackChanged);
+ Response setScriptSource(
+ const String16& sourceID, v8::Local<v8::String> newSource, bool dryRun,
+ protocol::Maybe<protocol::Runtime::ExceptionDetails>*,
+ JavaScriptCallFrames* newCallFrames, protocol::Maybe<bool>* stackChanged,
+ bool* compileError);
JavaScriptCallFrames currentCallFrames(int limit = 0);
// Each script inherits debug data from v8::Context where it has been
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698