Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2471583002: [Mac] Change the omnibox decoration padding (Closed)

Created:
4 years, 1 month ago by spqchan
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Change the omnibox decoration padding - Fixed the spacing for the RHS omnibox icons - Changed how the LHS omnibox icon paddings are calculated so that it will be easier to draw a hover background in a follow up CL. - NOTE: the LHS omnibox icons spacing shouldn't be changed. BUG=633156, 588377 Committed: https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c Cr-Commit-Position: refs/heads/master@{#429658}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Added a TODO #

Patch Set 4 : Fixed tests #

Messages

Total messages: 26 (16 generated)
spqchan
PTAL
4 years, 1 month ago (2016-11-01 20:03:50 UTC) #4
spqchan
On 2016/11/01 20:03:50, spqchan wrote: > PTAL whoops, it looks like I need to update ...
4 years, 1 month ago (2016-11-02 00:21:32 UTC) #10
spqchan
On 2016/11/02 00:21:32, spqchan wrote: > On 2016/11/01 20:03:50, spqchan wrote: > > PTAL > ...
4 years, 1 month ago (2016-11-02 23:35:01 UTC) #15
shrike
lgtm
4 years, 1 month ago (2016-11-03 18:04:04 UTC) #16
spqchan
thanks! +avi for ownership
4 years, 1 month ago (2016-11-03 18:22:59 UTC) #18
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-03 18:27:37 UTC) #19
spqchan
On 2016/11/03 18:27:37, Avi wrote: > lgtm thanks!
4 years, 1 month ago (2016-11-03 18:28:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471583002/60001
4 years, 1 month ago (2016-11-03 18:29:56 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-03 18:38:28 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:45:41 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c
Cr-Commit-Position: refs/heads/master@{#429658}

Powered by Google App Engine
This is Rietveld 408576698