Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2471573007: [turbolizer] Recognize nested [] in json file (Closed)

Created:
4 years, 1 month ago by Jing
Modified:
4 years, 1 month ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com, Weiliang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Recognize nested [] in json file fix schedule viewing for text like 1756: HeapConstant[0x3ff62d29 <FixedArray[31]>] : HeapConstant(0x3ff62d29 <FixedArray[31]>) BUG= Committed: https://crrev.com/9e3eafdd284e0f679fd69e65e13fd06f49462d15 Cr-Commit-Position: refs/heads/master@{#40786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/turbolizer/schedule-view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jing
4 years, 1 month ago (2016-11-04 01:46:41 UTC) #2
danno
lgtm
4 years, 1 month ago (2016-11-04 11:49:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471573007/1
4 years, 1 month ago (2016-11-07 01:26:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 01:50:56 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e3eafdd284e0f679fd69e65e13fd06f49462d15
Cr-Commit-Position: refs/heads/master@{#40786}

Powered by Google App Engine
This is Rietveld 408576698