content/browser/presentation/presentation_service_impl.cc - Issue 2471573005: [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_service_impl.cc

Issue 2471573005: [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging (Closed)

Patch Set: call OPM.unregisterOPMController() in PresentationFrame::Reset() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/presentation/presentation_service_impl.cc

diff --git a/content/browser/presentation/presentation_service_impl.cc b/content/browser/presentation/presentation_service_impl.cc

index c04a4d01167d50eab71fa82d2a02458e19cef6f9..8c3bdab4e699585fcb73132dc6746bfb77ef09c2 100644

--- a/content/browser/presentation/presentation_service_impl.cc

+++ b/content/browser/presentation/presentation_service_impl.cc

@@ -523,9 +523,9 @@ void PresentationServiceImpl::OnReceiverConnectionAvailable(

PresentationConnectionPtr&& controller) {

DVLOG(2) << "PresentationServiceImpl::OnReceiverConnectionAvailable";

- // client_->OnReceiverConnectionAvailable(

- // blink::mojom::PresentationSessionInfo::From(session_info),

- // std::move(controller));

+ client_->OnReceiverConnectionAvailable(

+ blink::mojom::PresentationSessionInfo::From(session_info),

+ std::move(controller));

}

void PresentationServiceImpl::DidNavigateAnyFrame(