Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 2471573005: [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 0868ddaeef2ad3ba23625874d6c289df1d5fa545..b4c3d8551bb8559dfdb45ef69db2ed4941c497a2 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -92,7 +92,7 @@ class CONTENT_EXPORT PresentationServiceImpl
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
MaxPendingJoinSessionRequests);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForConnectionStateChangeAndChangeState);
+ ListenForConnectionStateChange);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
ListenForConnectionClose);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
@@ -237,9 +237,8 @@ class CONTENT_EXPORT PresentationServiceImpl
void OnSendMessageCallback(bool sent);
// Calls to |delegate_| to start listening for state changes for |connection|.
- // State changes will be returned via |OnConnectionStateChanged|. Change
- // |connection|'s state to 'connected' after listening.
- void ListenForConnectionStateChangeAndChangeState(
+ // State changes will be returned via |OnConnectionStateChanged|.
+ void ListenForConnectionStateChange(
const PresentationSessionInfo& connection);
// Passed to embedder's implementation of PresentationServiceDelegate for
« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698