extensions/renderer/script_injector.h - Issue 2471553003: Fix content script injection not working with PlzNavigate because of different navigation timings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injector.h

Issue 2471553003: Fix content script injection not working with PlzNavigate because of different navigation timings. (Closed)

Patch Set: review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/script_injector.h

diff --git a/extensions/renderer/script_injector.h b/extensions/renderer/script_injector.h

index cdc3741b50456800bf074a3f622293ba201f94a2..38c072de206c4bbe7e9807eac40845d1b4b4420e 100644

--- a/extensions/renderer/script_injector.h

+++ b/extensions/renderer/script_injector.h

@@ -64,7 +64,7 @@ class ScriptInjector {

virtual PermissionsData::AccessType CanExecuteOnFrame(

const InjectionHost* injection_host,

blink::WebLocalFrame* web_frame,

- int tab_id) const = 0;

+ int tab_id) = 0;

// Returns the javascript sources to inject at the given |run_location|.

// Only called if ShouldInjectJs() is true.