Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 2471553003: Fix content script injection not working with PlzNavigate because of different navigation timings. (Closed)
Patch Set: review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/programmatic_script_injector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/programmatic_script_injector.h
diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h
index aa510840b2e53de01dc63b1e30e76f8b8181b980..673a08ee598c555ef2deb5c622b4960d329f4085 100644
--- a/extensions/renderer/programmatic_script_injector.h
+++ b/extensions/renderer/programmatic_script_injector.h
@@ -23,8 +23,8 @@ namespace extensions {
// A ScriptInjector to handle tabs.executeScript().
class ProgrammaticScriptInjector : public ScriptInjector {
public:
- ProgrammaticScriptInjector(const ExtensionMsg_ExecuteCode_Params& params,
- content::RenderFrame* render_frame);
+ explicit ProgrammaticScriptInjector(
+ const ExtensionMsg_ExecuteCode_Params& params);
~ProgrammaticScriptInjector() override;
private:
@@ -42,7 +42,7 @@ class ProgrammaticScriptInjector : public ScriptInjector {
PermissionsData::AccessType CanExecuteOnFrame(
const InjectionHost* injection_host,
blink::WebLocalFrame* web_frame,
- int tab_id) const override;
+ int tab_id) override;
std::vector<blink::WebScriptSource> GetJsSources(
UserScript::RunLocation run_location,
std::set<std::string>* executing_scripts,
« no previous file with comments | « no previous file | extensions/renderer/programmatic_script_injector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698