extensions/renderer/script_injection_manager.cc - Issue 2471553003: Fix content script injection not working with PlzNavigate because of different navigation timings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 2471553003: Fix content script injection not working with PlzNavigate because of different navigation timings. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/script_injection_manager.cc

diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc

index 19c356f4c2b57eaca8d77d04c09092848b3bf335..50b5f338e95388f54ee8366af710b8209c875081 100644

--- a/extensions/renderer/script_injection_manager.cc

+++ b/extensions/renderer/script_injection_manager.cc

@@ -448,8 +448,7 @@ void ScriptInjectionManager::HandleExecuteCode(

}

std::unique_ptr<ScriptInjection> injection(new ScriptInjection(

- std::unique_ptr<ScriptInjector>(

- new ProgrammaticScriptInjector(params, render_frame)),

+ std::unique_ptr<ScriptInjector>(new ProgrammaticScriptInjector(params)),

render_frame, std::move(injection_host),

static_cast<UserScript::RunLocation>(params.run_at),

activity_logging_enabled_));