Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471553002:
DevTools: Make curtain handle dragging work again in Timeline overview (Closed)
|
Created:
4 years, 1 month ago by alph Modified:
4 years, 1 month ago Reviewers:
caseq CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Make curtain handle dragging work again in Timeline overview
Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734
Committed: https://crrev.com/994149609af33be61e0533399708851ed33d3479
Cr-Original-Commit-Position: refs/heads/master@{#429083}
Cr-Commit-Position: refs/heads/master@{#429145}
Patch Set 1 #Patch Set 2 : rebaseline #Messages
Total messages: 17 (8 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org
The CQ bit was checked by caseq@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Make curtain handle dragging work again in Timeline overview ========== to ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2470913002/ by pfeldman@chromium.org. The reason for reverting is: I'll reland it after the reformat..
Message was sent while issue was closed.
Description was changed from ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ========== to ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ==========
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2471553002/#ps20001 (title: "rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ========== to ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Cr-Commit-Position: refs/heads/master@{#429083} ========== to ========== DevTools: Make curtain handle dragging work again in Timeline overview Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 Committed: https://crrev.com/994149609af33be61e0533399708851ed33d3479 Cr-Original-Commit-Position: refs/heads/master@{#429083} Cr-Commit-Position: refs/heads/master@{#429145} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/994149609af33be61e0533399708851ed33d3479 Cr-Commit-Position: refs/heads/master@{#429145} |
