tests/compiler/dart2js/constant_expression_test.dart - Issue 2471543004: Fix compiler crash when we declare several (global) variables, but only define some of them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/constant_expression_test.dart

Issue 2471543004: Fix compiler crash when we declare several (global) variables, but only define some of them. (Closed)

Patch Set: cleanup Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/constant_expression_test.dart

diff --git a/tests/compiler/dart2js/constant_expression_test.dart b/tests/compiler/dart2js/constant_expression_test.dart

index 7013167e36397aff03fcf4bc0aaefc095f6a7b99..d0cefd8dcb9e8a26316f4822b6de83fee5c36bbb 100644

--- a/tests/compiler/dart2js/constant_expression_test.dart

+++ b/tests/compiler/dart2js/constant_expression_test.dart

@@ -147,8 +147,6 @@ class A<T> implements B {

}

class B<S> implements C {

const factory B({field1}) = A<B<S>>;

- // TODO(johnniwinther): Enable this when the constructor evaluator doesn't

Emily Fortuna 2016/11/02 00:05:25 seemed like this was enabled given the below line

Johnni Winther 2016/11/02 10:41:31 Acknowledged.

- // crash:

const factory B.named() = A<S>;

}

class C<U> {