Fix compiler crash when we declare several (global) variables, but only define some of them.

pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection';
 
 import 'package:js_runtime/shared/embedded_names.dart';
 
 import '../closure.dart';
 import '../common.dart';
@@ skipping 729 matching lines @@
         message: "Unexpected variable $variable for $resolvedAst."));
     inLazyInitializerExpression = true;
     ast.VariableDefinitions node = resolvedAst.node;
     ast.Node initializer = resolvedAst.body;
     assert(invariant(variable, initializer != null,
         message: "Non-constant variable $variable has no initializer."));
     openFunction(variable, node);
     visit(initializer);
     HInstruction value = pop();
     value = potentiallyCheckOrTrustType(value, variable.type);
-    ast.SendSet sendSet = node.definitions.nodes.head;
-    closeAndGotoExit(new HReturn(value,
-        sourceInformationBuilder.buildReturn(sendSet.assignmentOperator)));
-    return closeFunction();
+    // In the case of multiple declarations (and some definitions) on the same
+    // line, the source pointer needs to point to the right initialized
+    // variable. So find the specific initialized variable we are referring to.
+    ast.Node sourceInfoNode = initializer;
+    for (var definition in node.definitions) {
+      if (definition is ast.SendSet &&
+          definition.selector.toString() == variable.name) {

[Siggi Cherem (dart-lang), 2016/11/02 18:17:20]

toString is mainly something we use for debugging (for complex nodes it can
recreate a string representation of the ast). In this case I think it's safe to
assume that the selctor is an identifier and do:

  definition.selector.asIdentifier().source == variable.name

[Emily Fortuna, 2016/11/02 18:24:58]

Done.

+        sourceInfoNode = definition.assignmentOperator;

[Siggi Cherem (dart-lang), 2016/11/02 18:17:20]

let's add a break here as well (it doesn't change things, but we'd stop
iterating the rest of the definitions if there are more.

[Emily Fortuna, 2016/11/02 18:24:58]

Done.

+      }
+    }
+
+    closeAndGotoExit(new HReturn(value, sourceInformationBuilder.buildReturn(
+            sourceInfoNode)));
+    return closeFunction(); // token or source

[Siggi Cherem (dart-lang), 2016/11/02 18:17:20]

remove trailing comment?

[Emily Fortuna, 2016/11/02 18:24:58]

whoops thanks.

   }
 
   /**
    * Returns the constructor body associated with the given constructor or
    * creates a new constructor body, if none can be found.
    *
    * Returns [:null:] if the constructor does not have a body.
    */
   ConstructorBodyElement getConstructorBody(
       ResolvedAst constructorResolvedAst) {
@@ skipping 6282 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.helpers.DynamicRuntimeType;
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, closedWorld)));
   }
 }