Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471533004:
Antialias the dragged-link rounded rect (Closed)
|
Created:
4 years, 1 month ago by Tom (Use chromium acct) Modified:
4 years, 1 month ago Reviewers:
eae CC:
chromium-reviews, blink-reviews, dcheng Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAntialias the dragged-link rounded rect
Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does.
R=eae@chromium.org
BUG=661412
Committed: https://crrev.com/6761c70cab40a4a190078388422f1bced51f88ed
Cr-Commit-Position: refs/heads/master@{#429360}
Patch Set 1 #
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Antialias the dragged-link rounded rect Please see the associated bug for images describing what this CL does. R=eae@chromium.org ========== to ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org ==========
Description was changed from ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org ========== to ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org BUG=661412 ==========
So much nicer, LGTM! I don't suppose we have a good way to test this?
On 2016/11/02 02:35:18, eae wrote: > So much nicer, LGTM! > > I don't suppose we have a good way to test this? Unfortunately I don't know how to test this :(
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Yeah, me neither sadly. Please go ahead and land as is.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org BUG=661412 ========== to ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org BUG=661412 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org BUG=661412 ========== to ========== Antialias the dragged-link rounded rect Please see bug 661412 comments #0 and #1 for a before/after to explain what this CL does. R=eae@chromium.org BUG=661412 Committed: https://crrev.com/6761c70cab40a4a190078388422f1bced51f88ed Cr-Commit-Position: refs/heads/master@{#429360} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6761c70cab40a4a190078388422f1bced51f88ed Cr-Commit-Position: refs/heads/master@{#429360} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
