Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: gpu/command_buffer/service/buffer_manager.h

Issue 2471533003: Minor improvement in uniform block backing buffer validation. (Closed)
Patch Set: fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/buffer_manager.h
diff --git a/gpu/command_buffer/service/buffer_manager.h b/gpu/command_buffer/service/buffer_manager.h
index 2778a7328b97d001fc4a486af12fd67cd2f682f6..5546aad307b9b8a980f08d28ca9bf14907cbfb15 100644
--- a/gpu/command_buffer/service/buffer_manager.h
+++ b/gpu/command_buffer/service/buffer_manager.h
@@ -337,10 +337,6 @@ class GPU_EXPORT BufferManager : public base::trace_event::MemoryDumpProvider {
const char* func_name,
const char* message_tag);
- uint32_t mapped_buffer_count() const {
- return mapped_buffer_count_;
- }
-
private:
friend class Buffer;
friend class TestHelper; // Needs access to DoBufferData.
@@ -391,9 +387,6 @@ class GPU_EXPORT BufferManager : public base::trace_event::MemoryDumpProvider {
GLenum usage,
bool use_shadow);
- void IncreaseMappedBufferCount();
- void DecreaseMappedBufferCount();
-
std::unique_ptr<MemoryTypeTracker> memory_type_tracker_;
MemoryTracker* memory_tracker_;
scoped_refptr<FeatureInfo> feature_info_;
@@ -420,10 +413,6 @@ class GPU_EXPORT BufferManager : public base::trace_event::MemoryDumpProvider {
bool lost_context_;
bool use_client_side_arrays_for_stream_buffers_;
- // Keep track of total mapped buffer count. In most use cases it should be 0,
- // so we could bypass checking each individual buffer as an optimization.
- uint32_t mapped_buffer_count_;
-
DISALLOW_COPY_AND_ASSIGN(BufferManager);
};
« no previous file with comments | « no previous file | gpu/command_buffer/service/buffer_manager.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698