Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Issue 2471523005: [turbofan] Disable usage of {maybe_assigned} variable flag. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable usage of {maybe_assigned} variable flag. This disables the usage of the {maybe_assigned} flag that the variable resolution computes for each variable on non-asm.js code. Note that the analysis is fundamentally broken for destructuring and top-level lexical variables. Also note that this still uses the analysis for asm.js code even though it is not validated. One can still trigger the bug by using invalid constructs within a function marked with "use asm". The fix is intentionally minimal so that it can be merged to release branches. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-659915 BUG=chromium:659915 Committed: https://crrev.com/b02e7fb86ec3831bf688b5550b1e97b8b7891df1 Cr-Commit-Position: refs/heads/master@{#40716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +5 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-659915a.js View 1 chunk +24 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-659915b.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-03 09:54:32 UTC) #4
Benedikt Meurer
LGTM.
4 years, 1 month ago (2016-11-03 09:55:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471523005/1
4 years, 1 month ago (2016-11-03 10:21:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 10:23:43 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b02e7fb86ec3831bf688b5550b1e97b8b7891df1
Cr-Commit-Position: refs/heads/master@{#40716}

Powered by Google App Engine
This is Rietveld 408576698