Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: cc/input/input_handler.h

Issue 2471523002: Make touch events uncancelable during fling when they are on the current active scroll layer (Closed)
Patch Set: clean up code Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/input_handler.h
diff --git a/cc/input/input_handler.h b/cc/input/input_handler.h
index 9b96db789d1d03c4a5fc6fc655288ffb3ad0f0d1..fd4da696c3f463910ff2e66ba48cd01f90231591 100644
--- a/cc/input/input_handler.h
+++ b/cc/input/input_handler.h
@@ -105,6 +105,8 @@ class CC_EXPORT InputHandler {
NON_BUBBLING_GESTURE
};
+ enum TouchStartHitResult { HANDLER, SAME_LAYER, DIFFERENT_LAYER };
tdresser 2016/11/04 17:15:20 These names aren't clear to me. Same layer as what
+
// Binds a client to this handler to receive notifications. Only one client
// can be bound to an InputHandler. The client must live at least until the
// handler calls WillShutdown() on the client.
@@ -190,7 +192,8 @@ class CC_EXPORT InputHandler {
// Whether the page should be given the opportunity to suppress scrolling by
// consuming touch events that started at |viewport_point|.
tdresser 2016/11/04 17:15:20 Update this comment.
lanwei 2016/11/11 18:22:45 Done.
- virtual bool DoTouchEventsBlockScrollAt(const gfx::Point& viewport_point) = 0;
+ virtual TouchStartHitResult DoTouchEventsBlockScrollAt(
+ const gfx::Point& viewport_point) = 0;
// Calling CreateLatencyInfoSwapPromiseMonitor() to get a scoped
// LatencyInfoSwapPromiseMonitor. During the life time of the

Powered by Google App Engine
This is Rietveld 408576698