Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2471493004: Revert of Enable shared memory for field trials (Closed)

Created:
4 years, 1 month ago by Charlie Reis
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable shared memory for field trials (patchset #2 id:20001 of https://codereview.chromium.org/2469503003/ ) Reason for revert: Appears to have caused renderer processes to lose knowledge of Finch trials, which led to a large spike in CreateFrame crashes for OOPIFs in https://crbug.com/661617. Original issue's description: > Enable shared memory for field trials > > This turns on the flag for using shared memory to share field trials between processes. For more context, see: > > The design document: go/share-field-trials > > The related previous CLs: > https://codereview.chromium.org/2365273004/ > https://codereview.chromium.org/2412113002/ > https://codereview.chromium.org/2449143002/ > https://codereview.chromium.org/2453093002/ > https://codereview.chromium.org/2449783007/ > https://codereview.chromium.org/2456723004/ > https://codereview.chromium.org/2453933004/ > > BUG=131632 > > Committed: https://crrev.com/4446189e8148980b9a245cb1157e8a695bac35d1 > Cr-Commit-Position: refs/heads/master@{#429042} TBR=asvitkine@chromium.org,lawrencewu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=131632 Committed: https://crrev.com/879e4e0e450d21fc6eb22dde4456362cc0fc335d Cr-Commit-Position: refs/heads/master@{#429440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Created Revert of Enable shared memory for field trials
4 years, 1 month ago (2016-11-02 21:35:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471493004/1
4 years, 1 month ago (2016-11-02 21:36:41 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 1 month ago (2016-11-02 21:40:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 23:06:21 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 23:07:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/879e4e0e450d21fc6eb22dde4456362cc0fc335d
Cr-Commit-Position: refs/heads/master@{#429440}

Powered by Google App Engine
This is Rietveld 408576698