Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2471493003: [heap] reorder empty scope info in the root list. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] reorder empty scope info in the root list. Apparently the previous clean up has regressed performance in some cases. This is an attempt to recover these regressions. R=ulan@chromium.org BUG=chromium:661567 Committed: https://crrev.com/e3f2910da7cbe509045de0fd2ce2768ba3c078a1 Cr-Commit-Position: refs/heads/master@{#40707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/heap.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Yang
4 years, 1 month ago (2016-11-02 13:02:42 UTC) #1
ulan
lgtm
4 years, 1 month ago (2016-11-02 14:30:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471493003/1
4 years, 1 month ago (2016-11-02 15:17:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 15:19:24 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f2910da7cbe509045de0fd2ce2768ba3c078a1
Cr-Commit-Position: refs/heads/master@{#40707}

Powered by Google App Engine
This is Rietveld 408576698