Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2471453002: Fix for MediaSessionObserver.stopObserving (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fox for MediaSessionObserver.stopObserving MediaSessionObserver should remove the reference to MediaSessionImpl when it stops observing. This CL fixes this issue. BUG=658678 Committed: https://crrev.com/59cad301881152cdc22382923cb2ccbc8b56bbbc Cr-Commit-Position: refs/heads/master@{#429037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Zhiqiang Zhang (Slow)
PTAL Just found I forgot to dereference when stop observing in Java.
4 years, 1 month ago (2016-11-01 16:48:18 UTC) #3
boliu
lgtm does it really matter though?
4 years, 1 month ago (2016-11-01 16:51:03 UTC) #4
Zhiqiang Zhang (Slow)
On 2016/11/01 16:51:03, boliu wrote: > lgtm > > does it really matter though? Just ...
4 years, 1 month ago (2016-11-01 17:00:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471453002/1
4 years, 1 month ago (2016-11-01 17:01:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 17:37:34 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:53:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59cad301881152cdc22382923cb2ccbc8b56bbbc
Cr-Commit-Position: refs/heads/master@{#429037}

Powered by Google App Engine
This is Rietveld 408576698