Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: components/gcm_driver/gcm_client_impl.h

Issue 2471433003: [GCM] Update ResetStore histograms (Closed)
Patch Set: Mark old histo as obsolete Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/gcm_driver/gcm_client_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_client_impl.h
diff --git a/components/gcm_driver/gcm_client_impl.h b/components/gcm_driver/gcm_client_impl.h
index dcda57db288946f2086be305cbdbe23ce51c5969..6700e0c7e0b5ddde0560b009ce18c95f89f81776 100644
--- a/components/gcm_driver/gcm_client_impl.h
+++ b/components/gcm_driver/gcm_client_impl.h
@@ -175,6 +175,16 @@ class GCMClientImpl
std::set<std::string> last_checkin_accounts;
};
+ // Reasons for resetting the GCM Store.
+ // Note: this enum is recorded into a histogram. Do not change enum value
+ // or order.
+ enum ResetReason {
+ LOAD_FAILURE, // GCM store failed to load, but the store exists.
+ CHECKIN_REJECTED, // Checkin was rejected by server.
+
+ RESET_REASON_COUNT,
+ };
+
// Collection of pending registration requests. Keys are RegistrationInfo
// instance, while values are pending registration requests to obtain a
// registration ID for requesting application.
@@ -220,7 +230,7 @@ class GCMClientImpl
// Starts a login on mcs_client_.
void StartMCSLogin();
// Resets the GCM store when it is corrupted.
- void ResetStore();
+ void ResetStore(ResetReason reset_reason);
// Sets state to ready. This will initiate the MCS login and notify the
// delegates.
void OnReady(const std::vector<AccountMapping>& account_mappings,
« no previous file with comments | « no previous file | components/gcm_driver/gcm_client_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698