Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2471433003: [GCM] Update ResetStore histograms (Closed)

Created:
4 years, 1 month ago by Nicolas Zea
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo, rkaplow
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, asvitkine+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GCM] Update ResetStore histograms Adds a new GCM.ResetStoreReason histogram, and renames the old GCM.ResetStore histogram to GCM.ResetStoreError (for clarity). BUG=659373 Committed: https://crrev.com/e6e40418c02f84417b973026ec6d7e515a4c46ba Cr-Commit-Position: refs/heads/master@{#430056}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Mark old histo as obsolete #

Total comments: 2

Patch Set 4 : Update owner #

Patch Set 5 : Rebase and pretty print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M components/gcm_driver/gcm_client_impl.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Nicolas Zea
+Peter for GCM, Robert for histograms
4 years, 1 month ago (2016-11-02 00:25:36 UTC) #6
rkaplow
lgtm
4 years, 1 month ago (2016-11-02 15:30:43 UTC) #9
Peter Beverloo
lgtm, thanks! https://codereview.chromium.org/2471433003/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2471433003/diff/40001/tools/metrics/histograms/histograms.xml#newcode18458 tools/metrics/histograms/histograms.xml:18458: + <owner>jianli@chromium.org</owner> nit: zea@ since Jian doesn't ...
4 years, 1 month ago (2016-11-02 18:05:58 UTC) #10
Nicolas Zea
https://codereview.chromium.org/2471433003/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2471433003/diff/40001/tools/metrics/histograms/histograms.xml#newcode18458 tools/metrics/histograms/histograms.xml:18458: + <owner>jianli@chromium.org</owner> On 2016/11/02 18:05:58, Peter Beverloo wrote: > ...
4 years, 1 month ago (2016-11-02 18:27:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471433003/60001
4 years, 1 month ago (2016-11-02 18:27:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295120)
4 years, 1 month ago (2016-11-02 18:39:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471433003/80001
4 years, 1 month ago (2016-11-04 20:12:17 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-04 23:06:15 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 23:10:03 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e6e40418c02f84417b973026ec6d7e515a4c46ba
Cr-Commit-Position: refs/heads/master@{#430056}

Powered by Google App Engine
This is Rietveld 408576698