device/vr/vr_service.mojom - Issue 2471433002: Implement WebVR presentation pausing for VR Shell Menu Mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/vr/vr_service.mojom

Issue 2471433002: Implement WebVR presentation pausing for VR Shell Menu Mode (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/vr_shell/vr_shell_delegate.cc ('K') | « device/vr/vr_device_manager.cc ('k') | third_party/WebKit/Source/modules/vr/VRController.h » ('j') | third_party/WebKit/Source/modules/vr/VRDisplay.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module device;	5 module device;

6	6

7 // A field of view, given by 4 degrees describing the view from a center point.	7 // A field of view, given by 4 degrees describing the view from a center point.

8 struct VRFieldOfView {	8 struct VRFieldOfView {

9 float upDegrees;	9 float upDegrees;

10 float downDegrees;	10 float downDegrees;

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 ExitPresent(uint32 index);	76 ExitPresent(uint32 index);

77 SubmitFrame(uint32 index, VRPose? pose);	77 SubmitFrame(uint32 index, VRPose? pose);

78 UpdateLayerBounds(uint32 index, VRLayerBounds leftBounds, VRLayerBounds rightB ounds);	78 UpdateLayerBounds(uint32 index, VRLayerBounds leftBounds, VRLayerBounds rightB ounds);

79 };	79 };

80	80

81 interface VRServiceClient {	81 interface VRServiceClient {

82 OnDisplayChanged(VRDisplay display);	82 OnDisplayChanged(VRDisplay display);

83 OnExitPresent(uint32 index);	83 OnExitPresent(uint32 index);

84 OnDisplayConnected(VRDisplay display);	84 OnDisplayConnected(VRDisplay display);

85 OnDisplayDisconnected(uint32 index);	85 OnDisplayDisconnected(uint32 index);

	86 OnPausePresent(uint32 index);

	87 OnResumePresent(uint32 index);
	bajones 2016/11/01 18:11:31 Let's prefer the verbiage defined by the spec here Let's prefer the verbiage defined by the spec here, which is blur/focus. (https://w3c.github.io/webvr/#window-onvrdisplayblur-event) So these should be OnDisplayBlur and OnDisplayFocus. mthiesse 2016/11/02 14:39:02 Done. Show quoted text On 2016/11/01 18:11:31, bajones wrote: > Let's prefer the verbiage defined by the spec here, which is blur/focus. > (https://w3c.github.io/webvr/#window-onvrdisplayblur-event) So these should be > OnDisplayBlur and OnDisplayFocus. Done.
86 };	88 };

OLD	NEW