Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 247143007: Revert of SDK building script now uses package_version to extract. (Closed)

Created:
6 years, 8 months ago by hidehiko
Modified:
6 years, 8 months ago
CC:
chromium-reviews, binji, Sam Clegg, Derek Schuff
Visibility:
Public.

Description

Revert of SDK building script now uses package_version to extract. (https://codereview.chromium.org/235603004/) Reason for revert: This update breaks PPAPI*NonSfi tests on linux-32bits bot. See also crbug.com/365817 Original issue's description: > NaCl: Update revision in DEPS, r13018 -> r13062. > > Chromium NaCl scripts now uses package_version to extract. > > Now that we have split up the toolchain into multiple tars, we should > use the package versioning script to manage which tars to extract. > Unfortunately, currently the SDK uses different directory names compared > to what the NaCl toolchain directories normally use, so we also must map > and move the toolchain directories to the SDK ones. > > TEST= trybots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265303 TBR=noelallen@chromium.org,bradnelson@chromium.org,jvoung@chromium.org,mseaborn@chromium.org,dyen@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -86 lines) Patch
M DEPS View 2 chunks +3 lines, -2 lines 0 comments Download
M build/download_nacl_toolchains.py View 2 chunks +16 lines, -12 lines 0 comments Download
M chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py View 1 chunk +3 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 5 chunks +87 lines, -56 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hidehiko
Created Revert of SDK building script now uses package_version to extract.
6 years, 8 months ago (2014-04-23 07:04:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/247143007/1
6 years, 8 months ago (2014-04-23 07:04:42 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 07:05:24 UTC) #3
Message was sent while issue was closed.
Change committed as 265559

Powered by Google App Engine
This is Rietveld 408576698