Issue 247143003: gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja

Issue 247143003: gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja (Closed)

Created:
6 years, 8 months ago by epoger

Modified:
6 years, 8 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja BUG=skia:2442 Committed: http://code.google.com/p/skia/source/detail?r=14313

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	gyp/common_conditions.gypi	View		2 chunks	+18 lines, -11 lines	0 comments	Download

Total messages: 8 (0 generated)

epoger

Cary- please try this one, and let me know if it works for you.

6 years, 8 months ago (2014-04-22 18:32:09 UTC) #1

caryclark

On 2014/04/22 18:32:09, epoger wrote: > Cary- please try this one, and let me know ...

6 years, 8 months ago (2014-04-22 18:40:07 UTC) #2

epoger

On 2014/04/22 18:40:07, caryclark wrote: > On 2014/04/22 18:32:09, epoger wrote: > > Cary- please ...

6 years, 8 months ago (2014-04-22 18:41:05 UTC) #3

caryclark

On 2014/04/22 18:41:25, caryclark wrote: > lgtm and, Thanks!

6 years, 8 months ago (2014-04-22 18:41:41 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/247143003/1

6 years, 8 months ago (2014-04-22 18:41:42 UTC) #7

Message was sent while issue was closed.

Change committed as 14313