Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471413006:
Disable multi-planar import for now (Closed)
|
Created:
4 years, 1 month ago by gurchetansingh Modified:
4 years, 1 month ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable multi-planar import for now
Minigbm incorrectly calculates the plane sizes currently. The API
needs to be changed, so revert this for now. The plan is to land:
https://chromium-review.googlesource.com/#/c/406485/
and then undo the changes in this commit, and explicitly specify the
plane sizes.
BUG=chromium:618516
TEST=chrome builds
Committed: https://crrev.com/cfa58e69b33fff86f7f0f9589b053e7d57204704
Cr-Commit-Position: refs/heads/master@{#431007}
Patch Set 1 #Patch Set 2 : fix typo #Patch Set 3 : Make sure to import only one plane #
Total comments: 2
Patch Set 4 : Changed where number of planes is checked #
Total comments: 2
Patch Set 5 : Stopped using bitwise operator #Messages
Total messages: 29 (12 generated)
Description was changed from ========== Revert "ozone: Import multi-planar gbms." Minigbm incorrectly calculates the plane size currently. The API needs to be changed for now, so revert this for now. The plan is land: https://chromium-review.googlesource.com/#/c/406485/ and then revert this revert. BUG=chromium:618516 TEST=chrome builds This reverts commit 61a0141f318f35bb12608a65dae28e070cd568c9. ========== to ========== Revert "ozone: Import multi-planar gbms." Minigbm incorrectly calculates the plane size currently. The API needs to be changed for now, so revert this for now. The plan is to land: https://chromium-review.googlesource.com/#/c/406485/ and then revert this revert. BUG=chromium:618516 TEST=chrome builds This reverts commit 61a0141f318f35bb12608a65dae28e070cd568c9. ==========
gurchetansingh@chromium.org changed reviewers: + dcastagna@chromium.org, dnicoara@chromium.org
gurchetansingh@chromium.org changed reviewers: + marcheu@chromium.org
The CQ bit was checked by gurchetansingh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
You'll actually need to add the code that fills fd_data.sizes before relanding. Btw, why don't you make sure we don't try to import multi planar buffers in this patch?
On 2016/11/04 23:57:48, Daniele Castagna wrote: > You'll actually need to add the code that fills fd_data.sizes before relanding. > > Btw, why don't you make sure we don't try to import multi planar buffers in this > patch? Done.
https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... ui/ozone/platform/drm/gpu/gbm_buffer.cc:197: if (use_scanout && !buffer->GetFramebufferId()) Wouldn't we hit this?
https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... ui/ozone/platform/drm/gpu/gbm_buffer.cc:169: bool use_scanout = gbm_device_is_format_supported( I was thinking of something like bool use_scanout = is_support() && planes.size() == 1.
Description was changed from ========== Revert "ozone: Import multi-planar gbms." Minigbm incorrectly calculates the plane size currently. The API needs to be changed for now, so revert this for now. The plan is to land: https://chromium-review.googlesource.com/#/c/406485/ and then revert this revert. BUG=chromium:618516 TEST=chrome builds This reverts commit 61a0141f318f35bb12608a65dae28e070cd568c9. ========== to ========== Disable multi-planar import for now Minigbm incorrectly calculates the plane sizes currently. The API needs to be changed, so revert this for now. The plan is to land: https://chromium-review.googlesource.com/#/c/406485/ and then undo the changes in this commit, and explicitly specify the plane sizes. BUG=chromium:618516 TEST=chrome builds ==========
On 2016/11/05 00:21:34, Daniele Castagna wrote: > https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... > File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): > > https://codereview.chromium.org/2471413006/diff/40001/ui/ozone/platform/drm/g... > ui/ozone/platform/drm/gpu/gbm_buffer.cc:169: bool use_scanout = > gbm_device_is_format_supported( > I was thinking of something like > bool use_scanout = is_support() && planes.size() == 1. done
LGTM/ https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... ui/ozone/platform/drm/gpu/gbm_buffer.cc:172: use_scanout &= (planes.size() == 1); nit: Why are you using a bitwise operator with a bool type?
https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... ui/ozone/platform/drm/gpu/gbm_buffer.cc:172: use_scanout &= (planes.size() == 1); On 2016/11/05 01:01:38, Daniele Castagna wrote: > nit: Why are you using a bitwise operator with a bool type? fixed
The CQ bit was checked by gurchetansingh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcastagna@chromium.org Link to the patchset: https://codereview.chromium.org/2471413006/#ps80001 (title: "Stopped using bitwise operator")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/05 01:11:53, gurchetansingh wrote: > https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... > File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): > > https://codereview.chromium.org/2471413006/diff/60001/ui/ozone/platform/drm/g... > ui/ozone/platform/drm/gpu/gbm_buffer.cc:172: use_scanout &= (planes.size() == > 1); > On 2016/11/05 01:01:38, Daniele Castagna wrote: > > nit: Why are you using a bitwise operator with a bool type? > > fixed Do we still need owner approval? If so, dnicoara can you review (see b/32726875)?
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by gurchetansingh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Disable multi-planar import for now
Minigbm incorrectly calculates the plane sizes currently. The API
needs to be changed, so revert this for now. The plan is to land:
https://chromium-review.googlesource.com/#/c/406485/
and then undo the changes in this commit, and explicitly specify the
plane sizes.
BUG=chromium:618516
TEST=chrome builds
==========
to
==========
Disable multi-planar import for now
Minigbm incorrectly calculates the plane sizes currently. The API
needs to be changed, so revert this for now. The plan is to land:
https://chromium-review.googlesource.com/#/c/406485/
and then undo the changes in this commit, and explicitly specify the
plane sizes.
BUG=chromium:618516
TEST=chrome builds
==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from
==========
Disable multi-planar import for now
Minigbm incorrectly calculates the plane sizes currently. The API
needs to be changed, so revert this for now. The plan is to land:
https://chromium-review.googlesource.com/#/c/406485/
and then undo the changes in this commit, and explicitly specify the
plane sizes.
BUG=chromium:618516
TEST=chrome builds
==========
to
==========
Disable multi-planar import for now
Minigbm incorrectly calculates the plane sizes currently. The API
needs to be changed, so revert this for now. The plan is to land:
https://chromium-review.googlesource.com/#/c/406485/
and then undo the changes in this commit, and explicitly specify the
plane sizes.
BUG=chromium:618516
TEST=chrome builds
Committed: https://crrev.com/cfa58e69b33fff86f7f0f9589b053e7d57204704
Cr-Commit-Position: refs/heads/master@{#431007}
==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/cfa58e69b33fff86f7f0f9589b053e7d57204704 Cr-Commit-Position: refs/heads/master@{#431007} |
