Revert of X11: Use CopyFromParent colormap when possible

Revert of X11: Use CopyFromParent colormap when possible (patchset #2 id:20001 of https://codereview.chromium.org/2471073002/ )

Reason for revert:
This causes crashes on Linux with --use-gl=angle.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New%20Intel%29/builds/4741
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/44802
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVIDIA%29/builds/34419

Crashing stack:
#0  XVisualIDFromVisual (visual=0x0) at ../../src/Misc.c:60
#1  0x00007f6ab2e4a7bb in GetPlatformANGLEDisplay () at ../../ui/gl/gl_surface_egl.cc:153
#2  0x00007f6ab2e482a8 in GetDisplayFromType () at ../../ui/gl/gl_surface_egl.cc:170
#3  InitializeDisplay () at ../../ui/gl/gl_surface_egl.cc:621
#4  0x00007f6ab2e47d37 in InitializeOneOff () at ../../ui/gl/gl_surface_egl.cc:471
#5  0x00007f6ab5cad2d5 in InitializeGLOneOffPlatform () at ../../ui/gl/init/gl_initializer_x11.cc:141
#6  0x00007f6ab5cad0d6 in InitializeGLOneOffImplementation () at ../../ui/gl/init/gl_factory.cc:65
#7  0x00007f6ab5cace70 in InitializeGLOneOff () at ../../ui/gl/init/gl_factory.cc:56
#8  0x00007f6ab5e46c2e in InitializeAndStartSandbox () at ../../gpu/ipc/service/gpu_init.cc:178
#9  0x00007f6ab42ba16b in GpuMain () at ../../content/gpu/gpu_main.cc:250
#10 0x00007f6ab1eb5267 in RunNamedProcessTypeMain () at ../../content/app/content_main_runner.cc:408
#11 0x00007f6ab1eb5cdb in Run () at ../../content/app/content_main_runner.cc:776
#12 0x00007f6ab1eb4650 in ContentMain () at ../../content/app/content_main.cc:20
#13 0x00007f6ab0819c5d in ChromeMain () at ../../chrome/app/chrome_main.cc:97
#14 0x00007f6aa92d0f45 in __libc_start_main (main=0x7f6ab0819c10 <main>, argc=17, argv=0x7ffd9a4f1468, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd9a4f1458) at libc-start.c:287
#15 0x00007f6ab0819b31 in _start ()

Original issue's description:
> X11: Use CopyFromParent colormap when possible
>
> This CL is a small performance optimization.  Previously,
> XVisualManager always allocated a new colormap for every used visual.
> However, on non-compositing WMs, on some drivers, this could result in
> an expensive copy-on-present for every frame, but this should not
> occur when using the root window's colormap.
>
> BUG=661697
>
> Committed: https://crrev.com/a03a18c3b24025623e0f2ad96ac56b8427fda7d3
> Cr-Commit-Position: refs/heads/master@{#429371}

TBR=erg@chromium.org,derat@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661697
Committed: https://crrev.com/6d75c767fb070823381289f044d14fdc9928e5c6
Cr-Commit-Position: refs/heads/master@{#429504}

[ynovikov, 2016-11-03 01:21:12]

Created Revert of X11: Use CopyFromParent colormap when possible

[ynovikov, 2016-11-03 01:22:11]

ynovikov@chromium.org changed reviewers:
+ cwallez@chromium.org, geofflang@chromium.org, jmadill@chromium.org,
kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-03 01:32:16]

thomasanderson, erg, derat: apologies for the revert but these broke ANGLE on
Linux, which is a configuration Chromium is moving toward.

I'm preparing a CL which will run these tests on this tryserver:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional...

so that you can add the line

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

to your CL description to catch this failure before it lands again. (We only add
this tryserver automatically for selected sub-directories, and ui/ isn't one of
them, at least not yet.)

[Ken Russell (switch to Gerrit), 2016-11-03 01:32:29]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:32:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:32:57]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ken Russell (switch to Gerrit), 2016-11-03 01:33:28]

lgtm

[Ken Russell (switch to Gerrit), 2016-11-03 01:33:32]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:34:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:38:52]

Description was changed from

==========
Revert of X11: Use CopyFromParent colormap when possible (patchset #2 id:20001
of https://codereview.chromium.org/2471073002/ )

Reason for revert:
This causes crashes on Linux with --use-gl=angle.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVI...

Crashing stack:
#0  XVisualIDFromVisual (visual=0x0) at ../../src/Misc.c:60
#1  0x00007f6ab2e4a7bb in GetPlatformANGLEDisplay () at
../../ui/gl/gl_surface_egl.cc:153
#2  0x00007f6ab2e482a8 in GetDisplayFromType () at
../../ui/gl/gl_surface_egl.cc:170
#3  InitializeDisplay () at ../../ui/gl/gl_surface_egl.cc:621
#4  0x00007f6ab2e47d37 in InitializeOneOff () at
../../ui/gl/gl_surface_egl.cc:471
#5  0x00007f6ab5cad2d5 in InitializeGLOneOffPlatform () at
../../ui/gl/init/gl_initializer_x11.cc:141
#6  0x00007f6ab5cad0d6 in InitializeGLOneOffImplementation () at
../../ui/gl/init/gl_factory.cc:65
#7  0x00007f6ab5cace70 in InitializeGLOneOff () at
../../ui/gl/init/gl_factory.cc:56
#8  0x00007f6ab5e46c2e in InitializeAndStartSandbox () at
../../gpu/ipc/service/gpu_init.cc:178
#9  0x00007f6ab42ba16b in GpuMain () at ../../content/gpu/gpu_main.cc:250
#10 0x00007f6ab1eb5267 in RunNamedProcessTypeMain () at
../../content/app/content_main_runner.cc:408
#11 0x00007f6ab1eb5cdb in Run () at ../../content/app/content_main_runner.cc:776
#12 0x00007f6ab1eb4650 in ContentMain () at ../../content/app/content_main.cc:20
#13 0x00007f6ab0819c5d in ChromeMain () at ../../chrome/app/chrome_main.cc:97
#14 0x00007f6aa92d0f45 in __libc_start_main (main=0x7f6ab0819c10 <main>,
argc=17, argv=0x7ffd9a4f1468, init=<optimized out>, 
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd9a4f1458)
at libc-start.c:287
#15 0x00007f6ab0819b31 in _start ()


Original issue's description:
> X11: Use CopyFromParent colormap when possible
> 
> This CL is a small performance optimization.  Previously,
> XVisualManager always allocated a new colormap for every used visual.
> However, on non-compositing WMs, on some drivers, this could result in
> an expensive copy-on-present for every frame, but this should not
> occur when using the root window's colormap.
> 
> BUG=661697
> 
> Committed: https://crrev.com/a03a18c3b24025623e0f2ad96ac56b8427fda7d3
> Cr-Commit-Position: refs/heads/master@{#429371}

TBR=erg@chromium.org,derat@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661697
==========

to

==========
Revert of X11: Use CopyFromParent colormap when possible (patchset #2 id:20001
of https://codereview.chromium.org/2471073002/ )

Reason for revert:
This causes crashes on Linux with --use-gl=angle.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVI...

Crashing stack:
#0  XVisualIDFromVisual (visual=0x0) at ../../src/Misc.c:60
#1  0x00007f6ab2e4a7bb in GetPlatformANGLEDisplay () at
../../ui/gl/gl_surface_egl.cc:153
#2  0x00007f6ab2e482a8 in GetDisplayFromType () at
../../ui/gl/gl_surface_egl.cc:170
#3  InitializeDisplay () at ../../ui/gl/gl_surface_egl.cc:621
#4  0x00007f6ab2e47d37 in InitializeOneOff () at
../../ui/gl/gl_surface_egl.cc:471
#5  0x00007f6ab5cad2d5 in InitializeGLOneOffPlatform () at
../../ui/gl/init/gl_initializer_x11.cc:141
#6  0x00007f6ab5cad0d6 in InitializeGLOneOffImplementation () at
../../ui/gl/init/gl_factory.cc:65
#7  0x00007f6ab5cace70 in InitializeGLOneOff () at
../../ui/gl/init/gl_factory.cc:56
#8  0x00007f6ab5e46c2e in InitializeAndStartSandbox () at
../../gpu/ipc/service/gpu_init.cc:178
#9  0x00007f6ab42ba16b in GpuMain () at ../../content/gpu/gpu_main.cc:250
#10 0x00007f6ab1eb5267 in RunNamedProcessTypeMain () at
../../content/app/content_main_runner.cc:408
#11 0x00007f6ab1eb5cdb in Run () at ../../content/app/content_main_runner.cc:776
#12 0x00007f6ab1eb4650 in ContentMain () at ../../content/app/content_main.cc:20
#13 0x00007f6ab0819c5d in ChromeMain () at ../../chrome/app/chrome_main.cc:97
#14 0x00007f6aa92d0f45 in __libc_start_main (main=0x7f6ab0819c10 <main>,
argc=17, argv=0x7ffd9a4f1468, init=<optimized out>, 
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd9a4f1458)
at libc-start.c:287
#15 0x00007f6ab0819b31 in _start ()


Original issue's description:
> X11: Use CopyFromParent colormap when possible
> 
> This CL is a small performance optimization.  Previously,
> XVisualManager always allocated a new colormap for every used visual.
> However, on non-compositing WMs, on some drivers, this could result in
> an expensive copy-on-present for every frame, but this should not
> occur when using the root window's colormap.
> 
> BUG=661697
> 
> Committed: https://crrev.com/a03a18c3b24025623e0f2ad96ac56b8427fda7d3
> Cr-Commit-Position: refs/heads/master@{#429371}

TBR=erg@chromium.org,derat@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661697
==========

[commit-bot: I haz the power, 2016-11-03 01:38:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 01:42:01]

Description was changed from

==========
Revert of X11: Use CopyFromParent colormap when possible (patchset #2 id:20001
of https://codereview.chromium.org/2471073002/ )

Reason for revert:
This causes crashes on Linux with --use-gl=angle.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVI...

Crashing stack:
#0  XVisualIDFromVisual (visual=0x0) at ../../src/Misc.c:60
#1  0x00007f6ab2e4a7bb in GetPlatformANGLEDisplay () at
../../ui/gl/gl_surface_egl.cc:153
#2  0x00007f6ab2e482a8 in GetDisplayFromType () at
../../ui/gl/gl_surface_egl.cc:170
#3  InitializeDisplay () at ../../ui/gl/gl_surface_egl.cc:621
#4  0x00007f6ab2e47d37 in InitializeOneOff () at
../../ui/gl/gl_surface_egl.cc:471
#5  0x00007f6ab5cad2d5 in InitializeGLOneOffPlatform () at
../../ui/gl/init/gl_initializer_x11.cc:141
#6  0x00007f6ab5cad0d6 in InitializeGLOneOffImplementation () at
../../ui/gl/init/gl_factory.cc:65
#7  0x00007f6ab5cace70 in InitializeGLOneOff () at
../../ui/gl/init/gl_factory.cc:56
#8  0x00007f6ab5e46c2e in InitializeAndStartSandbox () at
../../gpu/ipc/service/gpu_init.cc:178
#9  0x00007f6ab42ba16b in GpuMain () at ../../content/gpu/gpu_main.cc:250
#10 0x00007f6ab1eb5267 in RunNamedProcessTypeMain () at
../../content/app/content_main_runner.cc:408
#11 0x00007f6ab1eb5cdb in Run () at ../../content/app/content_main_runner.cc:776
#12 0x00007f6ab1eb4650 in ContentMain () at ../../content/app/content_main.cc:20
#13 0x00007f6ab0819c5d in ChromeMain () at ../../chrome/app/chrome_main.cc:97
#14 0x00007f6aa92d0f45 in __libc_start_main (main=0x7f6ab0819c10 <main>,
argc=17, argv=0x7ffd9a4f1468, init=<optimized out>, 
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd9a4f1458)
at libc-start.c:287
#15 0x00007f6ab0819b31 in _start ()


Original issue's description:
> X11: Use CopyFromParent colormap when possible
> 
> This CL is a small performance optimization.  Previously,
> XVisualManager always allocated a new colormap for every used visual.
> However, on non-compositing WMs, on some drivers, this could result in
> an expensive copy-on-present for every frame, but this should not
> occur when using the root window's colormap.
> 
> BUG=661697
> 
> Committed: https://crrev.com/a03a18c3b24025623e0f2ad96ac56b8427fda7d3
> Cr-Commit-Position: refs/heads/master@{#429371}

TBR=erg@chromium.org,derat@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661697
==========

to

==========
Revert of X11: Use CopyFromParent colormap when possible (patchset #2 id:20001
of https://codereview.chromium.org/2471073002/ )

Reason for revert:
This causes crashes on Linux with --use-gl=angle.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVI...

Crashing stack:
#0  XVisualIDFromVisual (visual=0x0) at ../../src/Misc.c:60
#1  0x00007f6ab2e4a7bb in GetPlatformANGLEDisplay () at
../../ui/gl/gl_surface_egl.cc:153
#2  0x00007f6ab2e482a8 in GetDisplayFromType () at
../../ui/gl/gl_surface_egl.cc:170
#3  InitializeDisplay () at ../../ui/gl/gl_surface_egl.cc:621
#4  0x00007f6ab2e47d37 in InitializeOneOff () at
../../ui/gl/gl_surface_egl.cc:471
#5  0x00007f6ab5cad2d5 in InitializeGLOneOffPlatform () at
../../ui/gl/init/gl_initializer_x11.cc:141
#6  0x00007f6ab5cad0d6 in InitializeGLOneOffImplementation () at
../../ui/gl/init/gl_factory.cc:65
#7  0x00007f6ab5cace70 in InitializeGLOneOff () at
../../ui/gl/init/gl_factory.cc:56
#8  0x00007f6ab5e46c2e in InitializeAndStartSandbox () at
../../gpu/ipc/service/gpu_init.cc:178
#9  0x00007f6ab42ba16b in GpuMain () at ../../content/gpu/gpu_main.cc:250
#10 0x00007f6ab1eb5267 in RunNamedProcessTypeMain () at
../../content/app/content_main_runner.cc:408
#11 0x00007f6ab1eb5cdb in Run () at ../../content/app/content_main_runner.cc:776
#12 0x00007f6ab1eb4650 in ContentMain () at ../../content/app/content_main.cc:20
#13 0x00007f6ab0819c5d in ChromeMain () at ../../chrome/app/chrome_main.cc:97
#14 0x00007f6aa92d0f45 in __libc_start_main (main=0x7f6ab0819c10 <main>,
argc=17, argv=0x7ffd9a4f1468, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd9a4f1458)
at libc-start.c:287
#15 0x00007f6ab0819b31 in _start ()

Original issue's description:
> X11: Use CopyFromParent colormap when possible
>
> This CL is a small performance optimization.  Previously,
> XVisualManager always allocated a new colormap for every used visual.
> However, on non-compositing WMs, on some drivers, this could result in
> an expensive copy-on-present for every frame, but this should not
> occur when using the root window's colormap.
>
> BUG=661697
>
> Committed: https://crrev.com/a03a18c3b24025623e0f2ad96ac56b8427fda7d3
> Cr-Commit-Position: refs/heads/master@{#429371}

TBR=erg@chromium.org,derat@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661697

Committed: https://crrev.com/6d75c767fb070823381289f044d14fdc9928e5c6
Cr-Commit-Position: refs/heads/master@{#429504}
==========

[commit-bot: I haz the power, 2016-11-03 01:42:02]

Patchset 1 (id:??) landed as
https://crrev.com/6d75c767fb070823381289f044d14fdc9928e5c6
Cr-Commit-Position: refs/heads/master@{#429504}